Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • added method for detecting helixes in a provided list of bodies
  • for workflow 10 in 26r1 targets

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.69%. Comparing base (de8df27) to head (3878c67).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/prepare_tools.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
+ Coverage   94.50%   94.69%   +0.19%     
==========================================
  Files         142      142              
  Lines       10585    10615      +30     
==========================================
+ Hits        10003    10052      +49     
+ Misses        582      563      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review September 17, 2025 14:33
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner September 17, 2025 14:33
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 17, 2025
@github-actions github-actions bot added the testing Anything related to tests label Sep 17, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Sep 18, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - after resolved, I'll approve =) Thanks @jacobrkerstetter

RobPasMue
RobPasMue previously approved these changes Sep 19, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) September 19, 2025 13:37
@github-actions github-actions bot added the maintenance Package and maintenance related label Sep 22, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Sep 23, 2025
@jacobrkerstetter jacobrkerstetter merged commit 7890c7d into main Sep 23, 2025
91 of 93 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/procedural_curve_impl branch September 23, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants