-
Notifications
You must be signed in to change notification settings - Fork 22
chore: v1 implementation of faces + edges stubs #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… chore/v1_faces_edges_impl # Conflicts: # src/ansys/geometry/core/_grpc/_services/v1/conversions.py
fixing some conversions and small bugs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
==========================================
- Coverage 92.19% 92.16% -0.04%
==========================================
Files 169 169
Lines 11787 11804 +17
==========================================
+ Hits 10867 10879 +12
- Misses 920 925 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments - but overall it looks good!
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
As title says
Issue linked
Related to #2388
Checklist
feat: extrude circle to cylinder)