Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • fixing any simple failures in tests
  • reworking boolean body operations
  • fixing rotate/translate method on bodies

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Dec 9, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner December 9, 2025 18:09
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks for the cleanup @jacobrkerstetter !

RobPasMue
RobPasMue previously approved these changes Dec 9, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 9, 2025 18:17
@RobPasMue
Copy link
Member

Looks like we broke the v0 behaviour..

@RobPasMue RobPasMue disabled auto-merge December 9, 2025 18:43
@RobPasMue
Copy link
Member

Have a look at the 24R1 failing stage

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (6a57201) to head (046fd87).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/geometry/core/_grpc/_services/v1/repair_tools.py 0.00% 16 Missing ⚠️
...ys/geometry/core/_grpc/_services/v1/conversions.py 0.00% 8 Missing ⚠️
...sys/geometry/core/_grpc/_services/v1/components.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   90.19%   90.17%   -0.03%     
==========================================
  Files         169      169              
  Lines       12135    12138       +3     
==========================================
  Hits        10945    10945              
- Misses       1190     1193       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 9, 2025 19:34
@RobPasMue RobPasMue disabled auto-merge December 9, 2025 20:14
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) December 9, 2025 20:47
@jacobrkerstetter jacobrkerstetter merged commit b4367a1 into main Dec 9, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the chore/v1_impl_cleanup branch December 9, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants