-
Notifications
You must be signed in to change notification settings - Fork 22
chore: v1 general cleanup #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… chore/v1_impl_cleanup
…sys-geometry into chore/v1_impl_cleanup
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - thanks for the cleanup @jacobrkerstetter !
|
Looks like we broke the v0 behaviour.. |
|
Have a look at the 24R1 failing stage |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
- Coverage 90.19% 90.17% -0.03%
==========================================
Files 169 169
Lines 12135 12138 +3
==========================================
Hits 10945 10945
- Misses 1190 1193 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Issue linked
Related to #2388
Checklist
feat: extrude circle to cylinder)