Skip to content

refactor: use pydantic for the settings module #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

refactor: use pydantic for the settings module #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
440d3d7
refactor: initial refactor to adopt pydantic
mhoeijm Oct 21, 2025
1120bcf
chore: adding changelog file 1259.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Oct 21, 2025
8cba7d2
refactor: remove remove_units method and references
mhoeijm Oct 21, 2025
ec8f4b5
refactor: new way to set values
mhoeijm Oct 21, 2025
74b9368
Merge branch 'refactor/adopt-pydantic-for-settings' of https://github…
mhoeijm Oct 21, 2025
fc8688b
refactor: fix test
mhoeijm Oct 21, 2025
bd80e86
refactor: fix test
mhoeijm Oct 21, 2025
c74378e
refactor: fix post tests
mhoeijm Oct 21, 2025
258edf3
refactor: add tests
mhoeijm Oct 21, 2025
d6e4f76
refactor: try ureg for strings in field validation
mhoeijm Oct 22, 2025
821d729
refactor: apply logic only to quantity annotated fields
mhoeijm Oct 22, 2025
f35095d
Merge branch 'main' into refactor/adopt-pydantic-for-settings
mhoeijm Oct 28, 2025
2080026
refactor: remove deprecated deserialization
mhoeijm Oct 28, 2025
37a4653
refactor: use pydantic for serialization
mhoeijm Oct 28, 2025
a7feae4
refactor: remove unused serialization method
mhoeijm Oct 28, 2025
1df615a
refactor: cleanup
mhoeijm Oct 28, 2025
1e32491
refactor: cleanup
mhoeijm Oct 28, 2025
0a6b159
refactor: cleanup unused methods
mhoeijm Oct 28, 2025
fc798d7
refactor: update all docstrings
mhoeijm Oct 28, 2025
5bc42a5
refactor: improve handling of zeropressure settings
mhoeijm Oct 28, 2025
fdd11de
refactor: update test settings
mhoeijm Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/changelog/1259.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use pydantic for the settings module
12 changes: 6 additions & 6 deletions src/ansys/health/heart/post/system_model_post.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,15 +181,15 @@ def __init__(self, dir: str):
s = SimulationSettings()
s.load(os.path.join(self.dir, "simulation_settings.yml"))
l_ed_pressure = (
s.mechanics.boundary_conditions.end_diastolic_cavity_pressure.left_ventricle.to(
"kilopascal"
).m
s.mechanics.boundary_conditions.end_diastolic_cavity_pressure.get("left_ventricle")
.to("kilopascal")
.m
)
if self.model_type == "BV":
r_ed_pressure = (
s.mechanics.boundary_conditions.end_diastolic_cavity_pressure.right_ventricle.to(
"kilopascal"
).m
s.mechanics.boundary_conditions.end_diastolic_cavity_pressure.get("right_ventricle")
.to("kilopascal")
.m
)

# get EOD volume
Expand Down
Loading