Remove hack to account for the timeout on start dpf server #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow done in dpf core.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
+ Coverage 90.00% 90.06% +0.05%
==========================================
Files 54 54
Lines 4154 4138 -16
==========================================
- Hits 3739 3727 -12
+ Misses 415 411 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roosre
changed the title
roosre
commented
May 15, 2025
| ansys-dpf-core == 0.10.1 | ||
| # result info for LSDyna is supported since Dec 23 (0.10.1) | ||
| # handling of timeout on start server is supported since 0.13.7 | ||
| ansys-dpf-core == 0.13.7 |
Contributor
Author
There was a problem hiding this comment.
This PR is postponed because it would set the minimum required verson of ansys-dpf-core to 0.13.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
This is now handled by DPF core and therefore the hack is no longer needed.
See ansys/pydpf-core#414