Update 03-fluids_isosurface.py #1173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 87.33% 87.23% -0.11%
==========================================
Files 81 81
Lines 9225 9225
==========================================
- Hits 8057 8047 -10
- Misses 1168 1178 +10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See error only when run on Linux here
https://github.com/ansys/pydpf-core/actions/runs/6496374240/job/17643189569#step:14:3636
See here for ref on master
https://github.com/ansys/pydpf-core/actions/runs/6251477896
At first I thought it was a problem of the example requiring 7.0 instead of 7.1 but it does not explain why it works on Windows runners... I have to check the CI
Edit: conclusion is that the last update to the example using operator iso_surfaces is not compatible with DPF 7.0, so we need to revert the example to its original state.