Skip to content

Conversation

@MichaelNale
Copy link
Contributor

Reverts #1164

@MichaelNale MichaelNale requested a review from PProfizi October 12, 2023 15:00
@PProfizi
Copy link
Contributor

PProfizi commented Oct 12, 2023

Necessary due to incompatibility between this new version of the example and DPF 2024.1.pre0.
This PR should be revert itself once ansys-dpf-core for DPF 2024.1.pre1 is under preparation.
@rafacanton to keep you updated

@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Oct 12, 2023
@PProfizi PProfizi added this to the v0.10.0 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1203 (1ec6c57) into master (7ad9470) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
+ Coverage   87.28%   87.37%   +0.09%     
==========================================
  Files          81       81              
  Lines        9224     9231       +7     
==========================================
+ Hits         8051     8066      +15     
+ Misses       1173     1165       -8     

@PProfizi PProfizi merged commit 8605173 into master Oct 12, 2023
@PProfizi PProfizi deleted the revert-1164-mnale/enhance_iso_contours_examples branch October 12, 2023 16:07
PProfizi added a commit that referenced this pull request Oct 12, 2023
@rafacanton
Copy link
Contributor

@PProfizi I don't understand. Wouldn't it be better to just mark it as limited to versions >=7.1?

@PProfizi
Copy link
Contributor

@rafacanton sadly no, since it already appears in the doc in its older version, we can't just bump the required version to a DPF verion that is not released yet. The point is we don't want to it disappear upon the release of a new ansys-dpf-core, which is what would happen if we mark it as requiring a higher DPF version than what is currently available.

@PProfizi
Copy link
Contributor

When generating the doc, we filter out the examples that require a DPF version superior to what is being used to generate the doc.

PProfizi added a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Related to PyDPF-Core examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants