Skip to content

Fix gltf #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Fix gltf #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df37386
Only run gltf example
PProfizi Oct 16, 2023
fb81e4a
Remove superfluous prints
PProfizi Oct 16, 2023
93f594a
Raise on stderr
PProfizi Oct 16, 2023
1804fb5
Fix path expansion
PProfizi Oct 16, 2023
5e6bba1
Final fix for create_sites_for_python_operators.ps1
PProfizi Oct 16, 2023
bdc35c0
Revert "Remove superfluous prints"
PProfizi Oct 16, 2023
6a5195d
Revert "Only run gltf example"
PProfizi Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/user_guide/create_sites_for_python_operators.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Write-Host "-pythonexe" $pythonexe
Write-Host "-tempfolder" $tempfolder

# Expand shortcut in path
$tempfolder = Resolve-Path -Path $tempfolder
$tempfolder = Resolve-Path -Path $tempfolder -Relative

Write-Host "make venv"
Start-Process $pythonexe -ArgumentList ("-m venv "+ $tempfolder+"\venv") -NoNewWindow -Wait
Expand Down
2 changes: 1 addition & 1 deletion examples/08-python-operators/02-python_operators_with_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
import subprocess

process = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
if process.returncode != 0 and process.stderr:
if process.stderr:
raise RuntimeError(
"Installing pygltf in a virtual environment failed with error:\n"
+ f"return code = {process.returncode}\n"
Expand Down