Allow GenericDataContainer as input/output of a CustomOperator and fix dpf-site.zip update #1376
Conversation
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
+ Coverage 86.09% 87.98% +1.88%
==========================================
Files 81 81
Lines 9417 9477 +60
==========================================
+ Hits 8108 8338 +230
+ Misses 1309 1139 -170 |
| custom_type_field.CustomTypeField, | ||
| external_operator_api.external_operator_put_out_custom_type_field, | ||
| ), | ||
| ( |
There was a problem hiding this comment.
@cbellot000 CodeCov says yes, which is weird because it is not tested explicitly.
There was a problem hiding this comment.
@cbellot000 BTW why do we have a type_to_output specific to the custom operators?
There was a problem hiding this comment.
@cbellot000 I just realized that to be be able to test this (and for this to even work), the changes need to be propagated to dpf-site.zip.
So either I add the capability to update the dpf-site.zip based on the current venv as we discussed previously, and use it at the start of test_python_plugins.py,
or we have to merge it first, then wait for a server sync loop to put it in dpf-site.zip and only then add the tests.
I'd tend to go towards the first proposal, which means I have to code and merge a PR with the dpf-site.zip update feature before this one.
There was a problem hiding this comment.
I see then, you can maybe add the test ad mark it as skip this way we can remove the skip later?
There was a problem hiding this comment.
@cbellot000 BTW why do we have a
type_to_outputspecific to the custom operators?
I don't understand, where would you put "external_operator_put_out_generic_data_container" instead?
Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
…ors_helpers.py Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
…talls of ansys-dpf-core Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
Signed-off-by: paul.profizi <[email protected]>
…x/custom_plugin_fixes
Signed-off-by: paul.profizi <[email protected]>
This reverts commit 8ca296c.
…s None (instead of instantiating an empty DPF object) Signed-off-by: paul.profizi <[email protected]>
…ator until server fix. Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Also fix some typehint and some imports.