Skip doctests in server_factory.py #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <[email protected]> Try skip problematic doctest lines Signed-off-by: paul.profizi <[email protected]> Try skip problematic doctest line Signed-off-by: paul.profizi <[email protected]> Try skip problematic doctest line Signed-off-by: paul.profizi <[email protected]> Try skip problematic doctest line Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 81 81
Lines 9543 9543
=======================================
Hits 8383 8383
Misses 1160 1160 |
rafacanton
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/ansys/pydpf-core/actions/runs/7904444681
These failures are random but fail 99% of the time. Only for these doctests, only on
Ubuntu, only forPython 3.10and only for the2024.2.pre0standalone.Will be investigated in a further bug issue but does not prevent from releasing.