Connect a Python string list to an operator accepting a StringField or a list of strings #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… take in a list of str Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
- Coverage 88.06% 86.89% -1.17%
==========================================
Files 83 83
Lines 9963 9974 +11
==========================================
- Hits 8774 8667 -107
- Misses 1189 1307 +118 |
Signed-off-by: paul.profizi <[email protected]>
PProfizi
changed the title
Fix Code Style
Fix Code Style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite operator pins documented as accepting lists of strings as inputs, the only object able to go through gRPC is the StringField. Hence when the operator pin indicates accepting a list of strings, PyDPF translates it into a StringField on-the-fly.