Get package version from library metadata #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 85.55% 81.29% -4.27%
==========================================
Files 83 83
Lines 9823 9825 +2
==========================================
- Hits 8404 7987 -417
- Misses 1419 1838 +419 |
BClappe
approved these changes
Jun 4, 2024
BClappe
approved these changes
Jun 4, 2024
| except ImportError: # Python < 3.10 (backport) | ||
| import importlib_metadata as importlib_metadata | ||
|
|
||
| __version__ = importlib_metadata.version("ansys-dpf-core") |
Contributor
There was a problem hiding this comment.
Where does it get the version from exactly? @PProfizi
Contributor
Author
There was a problem hiding this comment.
@BClappe from the pyproject.toml, meaning we have only one source of truth, and it is in the package metadata file.
Contributor
Author
There was a problem hiding this comment.
This is part of the work to adhere to PyAnsys best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements retrieval of the package's version from its metadata, as defined in the
pyproject.toml, as is shown in the PyAnsys best practices.