Skip to content

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Sep 3, 2024

Fixes #1670

A PR is required server-side for the LegacyGrpc server type to work.

@PProfizi PProfizi added the bug Something isn't working label Sep 3, 2024
@PProfizi PProfizi added this to the v0.13.1 milestone Sep 3, 2024
@PProfizi PProfizi self-assigned this Sep 3, 2024
Signed-off-by: paul.profizi <[email protected]>
@PProfizi PProfizi requested a review from a team as a code owner September 3, 2024 15:42
Signed-off-by: paul.profizi <[email protected]>
@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (52c4ce8) to head (7b7a528).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   86.93%   85.67%   -1.26%     
==========================================
  Files          83       83              
  Lines        9937     9937              
==========================================
- Hits         8639     8514     -125     
- Misses       1298     1423     +125     

@rafacanton
Copy link
Contributor

Thanks @PProfizi! Maybe just a fixture needed to protect the verison and then a PR on the server...

@PProfizi
Copy link
Contributor Author

PProfizi commented Sep 4, 2024

Thanks @PProfizi! Maybe just a fixture needed to protect the verison and then a PR on the server...

Yep, will do! I was waiting to know which versions would fail.

@rafacanton
Copy link
Contributor

Thanks @PProfizi! Maybe just a fixture needed to protect the verison and then a PR on the server...

Yep, will do! I was waiting to know which versions would fail.

BTW, quite nice and explicit error message :)

@PProfizi PProfizi merged commit c4c0e85 into master Sep 4, 2024
@PProfizi PProfizi deleted the fix/connect_any_as_input branch September 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operators in PyDPF Do Not Handle any Type Correctly

3 participants