Remove exclude of vtk 9.4.0 #1942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
- Coverage 88.17% 88.12% -0.06%
==========================================
Files 83 83
Lines 9973 9973
==========================================
- Hits 8794 8789 -5
- Misses 1179 1184 +5 |
|
Now a duplicate of #2229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests and validates the bump of
pydpf-actions/prepare_teststo usingpyvista/setup-headless-display-action@v3which should solve the issue withvtk==9.4.0.Note that
pyvista==0.44.2was just released which also excludesvtk==9.4.0until everything is fixed on their side.