Skip to content

Fix ansys installation finder #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix ansys installation finder #1966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ansys/dpf/core/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@
if base_path is None:
return base_path

paths = base_path.glob("v*")
paths = list(base_path.glob("v*"))

Check warning on line 186 in src/ansys/dpf/core/misc.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/dpf/core/misc.py#L186 

Added line #L186 was not covered by tests

if not list(paths):
Copy link
Contributor Author

@FedericoNegri FedericoNegri Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paths is a generator, it gets exhausted after first read

if not paths:

Check warning on line 188 in src/ansys/dpf/core/misc.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/dpf/core/misc.py#L188 

Added line #L188 was not covered by tests
return None

versions = {}
Expand Down
Loading