Skip to content

Conversation

@moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Feb 5, 2025

As the title states. Related to #296.

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 5, 2025

Moving to ready for review so all workflow runs can be observed.

@moe-ad moe-ad marked this pull request as ready for review February 5, 2025 11:23
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (fab9c63) to head (0aec059).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
+ Coverage   86.00%   86.44%   +0.43%     
==========================================
  Files          90       90              
  Lines       10233    10233              
==========================================
+ Hits         8801     8846      +45     
+ Misses       1432     1387      -45     

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 5, 2025

Tests that seem to cause trouble in retro versions between test-api, test-api_entry and test-server targets during parallel testing.

  • test_runtime_client_no_server => test-api_entry
  • test_write_to_file_data_tree => test-api
  • test_read_from_txt_data_tree => test-api
  • test_start_shutdown_start => test-server
  • test_start_after_shutting_down_server => test-server

My assessment -> next thing to try is exclude test-server from parallel tests. It doesn't take long anyway during sequential tests. Might solve the issue.

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 5, 2025

🚀 🚀 🚀
@jorgepiloto @PProfizi
I invite you to check out the new testing times.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insane, @moe-ad. Really nice to see this speed up on the CI/CD.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this improvement @moe-ad.

Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moe-ad !

@moe-ad moe-ad merged commit 775d101 into master Feb 6, 2025
46 checks passed
@moe-ad moe-ad deleted the ci/parallelize-some-tests branch February 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants