Comment failing tests for geometry helper #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… helper is wrong anyway
Contributor
|
@PProfizi 2 lines define a plane in 3D space only:
Otherwise (if they cross in 3D space), no plane can be defined... The API still makes sense, but it should give a meaningful error if not in the cases above |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
- Coverage 83.94% 83.84% -0.10%
==========================================
Files 90 90
Lines 10309 10309
==========================================
- Hits 8654 8644 -10
- Misses 1655 1665 +10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing tests in test_geometry.py on create_plane_from_lines as this helper is wrong anyway and this is blocking pyvista updates where a check has been added.
Hesitating with pure deprecation of the helper as defining a plane from two lines (four points) is undefined behavior anyway.