Skip to content

Conversation

@rafacanton
Copy link
Contributor

@rafacanton rafacanton commented May 12, 2025

Add missing homogeneities defined in the server but not in the client. Correct the value of the current homogeneity, which was mistaken by current_density.

@rafacanton rafacanton self-assigned this May 12, 2025
@rafacanton rafacanton added bug Something isn't working enhancement New feature or request labels May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.77%. Comparing base (3deb5ec) to head (06f86ce).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
- Coverage   83.78%   83.77%   -0.01%     
==========================================
  Files          90       90              
  Lines       10396    10399       +3     
==========================================
+ Hits         8710     8712       +2     
- Misses       1686     1687       +1     

@rafacanton rafacanton requested a review from PProfizi May 12, 2025 14:59
@rafacanton rafacanton changed the title Add missig homogeneities Add missing homogeneities May 12, 2025
@PProfizi
Copy link
Contributor

@rafacanton wouldn't it be better if this Enum was provided by the framework?

@PProfizi PProfizi added this to the 0.13.8 milestone May 13, 2025
@rafacanton
Copy link
Contributor Author

@rafacanton wouldn't it be better if this Enum was provided by the framework?

Yes, we discussed it about 1 month ago. We should fill this enum automatic upon code generation update, so it is entirely on the server. I created an operator to do that :)

@rafacanton rafacanton merged commit 7bb0107 into master May 13, 2025
80 of 81 checks passed
@rafacanton rafacanton deleted the rcanton/add_dt_homo branch May 13, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants