Test: update tests due to change in result order in result info for MAPDL #2713
Conversation
…eno/new_nodal_orientations
…eno/new_nodal_orientations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2713 +/- ##
==========================================
+ Coverage 84.38% 84.41% +0.02%
==========================================
Files 92 92
Lines 10899 10899
==========================================
+ Hits 9197 9200 +3
+ Misses 1702 1699 -3 |
| >>> model = dpf.Model(transient) | ||
| >>> result_info = model.metadata.result_info | ||
| >>> res = result_info.available_results[0] | ||
| >>> res = result_info.available_results[1] |
There was a problem hiding this comment.
@rafacanton, I will verify once my PR is merged as I deleted that part in the first one
There was a problem hiding this comment.
@rafacanton yes we do. And we have ways of making them retro-compatible, such as with a big ugly if on server.meets_version :).
|
@oparreno please make the title a bit more explicit. It should describe the change. |
oparreno
changed the title
|
@rafacanton, @PProfizi, would you please approve to put back the tests? Thanks |
|
it does indeed fail in the release CI https://github.com/ansys/pydpf-core/actions/runs/19063005720/job/54446869232#step:17:338 |
@oparreno So we will need to get the result by name and not by index |
rafacanton
dismissed
their stale review
resetting feedback due to CI Release breaking
Co-authored-by: Paul Profizi <[email protected]>
Co-authored-by: Paul Profizi <[email protected]>
Sorry I saw it passing in the CI and thought the issue was not there. |
Not your fault, we do not test for this in the dev CI. Maybe we should :). We usually fix this when trying to release but since we saw this one coming a mile away we might as well fix it directly in this PR. |
…eno/new_nodal_orientations_fix_pr
…ub.com/ansys/pydpf-core into oparreno/new_nodal_orientations_fix_pr
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
No description provided.