Skip to content

Conversation

@moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Nov 3, 2025

Related to #2701.

Once we have confirmed that this doesn't break anything in the pipelines, we probably need to undo the src/ changes and leave only the change to the template file for merging.

@moe-ad moe-ad self-assigned this Nov 3, 2025
@moe-ad moe-ad requested a review from PProfizi November 3, 2025 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post API tests on ubuntu-latest

Created by continue-on-error-comment

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (b1504b9) to head (526e6e0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2718      +/-   ##
==========================================
- Coverage   84.47%   84.45%   -0.02%     
==========================================
  Files          92       92              
  Lines       10899    10899              
==========================================
- Hits         9207     9205       -2     
- Misses       1692     1694       +2     

@PProfizi
Copy link
Contributor

PProfizi commented Nov 3, 2025

Hi @moe-ad actually if this works I'd rather keep the changes to the operators along with the change to the template.

@PProfizi PProfizi changed the title fix: update operators template refactor(operators): use operator-specific Input and Output classes in the template Nov 3, 2025
@PProfizi PProfizi added maintenance Repository structure maintenance refactoring Code refactoring only and removed maintenance Repository structure maintenance labels Nov 3, 2025
@github-actions github-actions bot added the bug Something isn't working label Nov 3, 2025
@PProfizi
Copy link
Contributor

PProfizi commented Nov 3, 2025

@moe-ad it looks like it is working, approving the PR.

@moe-ad moe-ad enabled auto-merge (squash) November 3, 2025 14:09
@moe-ad moe-ad merged commit 13dd437 into main Nov 3, 2025
47 checks passed
@moe-ad moe-ad deleted the fix/update-operators-template branch November 3, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working refactoring Code refactoring only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants