Skip to content

Conversation

@pyansys-ci-bot
Copy link
Collaborator

An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.

@pyansys-ci-bot pyansys-ci-bot requested a review from a team as a code owner November 13, 2025 08:22
@pyansys-ci-bot pyansys-ci-bot added the server-sync DO NOT USE, Related to automatic synchronization with the server label Nov 13, 2025
@@ -0,0 +1,475 @@
"""
PL2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oparreno @CyprienRusu I thought we said that PL2 was only going to be the internal name of the operator, not the external-facing one, didn't we?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that I did the suggestion on the units, we should change the scripting_name as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please stop using acronyms as user-facing names. Use explicit names whenever possible. We are not limited to 4 characters.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Some tests with 'continue-on-error: true' have failed:

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.38%. Comparing base (6dc6db5) to head (f02ff8c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
- Coverage   84.43%   84.38%   -0.06%     
==========================================
  Files          92       92              
  Lines       10916    10916              
==========================================
- Hits         9217     9211       -6     
- Misses       1699     1705       +6     

@rafacanton rafacanton closed this Nov 13, 2025
@rafacanton rafacanton deleted the maint/update_code_for_261_test_zip_gate_on_main branch November 13, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-sync DO NOT USE, Related to automatic synchronization with the server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants