-
Notifications
You must be signed in to change notification settings - Fork 23
Update generated code for DPF 261_daily on main #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some tests with 'continue-on-error: true' have failed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2745 +/- ##
===========================================
- Coverage 84.43% 45.99% -38.44%
===========================================
Files 92 92
Lines 10916 10916
===========================================
- Hits 9217 5021 -4196
- Misses 1699 5895 +4196 |
| Outputs | ||
| ------- | ||
| field: Field | ||
| extracted: Field or FieldsContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 AI...
| elif forced_value is not None: | ||
| warn( | ||
| DeprecationWarning( | ||
| f'Operator default_value: Input name "forced_value" is deprecated in favor of "primary_value".' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 was this change intentional? Forced value makes more sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it makes sense but it's not strongly required. I can revert if needed @rafacanton
|
All errors have been investigated and assigned - closing |
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.