Skip to content

fix: Improve parameter handling#1160

Merged
koubaa merged 3 commits intomainfrom
param-loading
Mar 6, 2026
Merged

fix: Improve parameter handling#1160
koubaa merged 3 commits intomainfrom
param-loading

Conversation

@koubaa
Copy link
Collaborator

@koubaa koubaa commented Mar 6, 2026

  • Undefined parameters now load gracefully (default values) instead of warning (the problem comes when writing, not reading)
  • Add ValueError on deck.write(retain_parameters=False) when unresolved refs exist
  • Refactor parameter parsing
  • Fix some bugs

… raw parsing for expressions

- Undefined parameters now load gracefully (default values) instead of warning
- Add ValueError on deck.write(retain_parameters=False) when unresolved refs exist
- Move PARAMETER_EXPRESSION raw parsing to dedicated helpers in lib/
- Simplify TableCard by removing dead parameter_set=None code paths
- Track parameter reference locations for detailed error messages
- Add ImportContext.format_location() for opaque location formatting
@koubaa koubaa requested a review from a team as a code owner March 6, 2026 19:37
@koubaa koubaa changed the title Improve parameter handling fix: Improve parameter handling Mar 6, 2026
@github-actions github-actions bot added testing Anything related to testing maintenance Generic maintenance related ci Pipelines maintenance related labels Mar 6, 2026
@koubaa koubaa mentioned this pull request Mar 6, 2026
2 tasks
@koubaa koubaa merged commit 179dc86 into main Mar 6, 2026
17 checks passed
@koubaa koubaa deleted the param-loading branch March 6, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related maintenance Generic maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants