feat: Create UI for meshing workflow. #4476
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gobot1234
reviewed
Oct 22, 2025
| try: | ||
| child_obj = parent[name] | ||
| except TypeError: | ||
| child_obj = getattr(parent, name.split(":")[0])[name.split(":")[-1]] |
There was a problem hiding this comment.
Suggested change
| child_obj = getattr(parent, name.split(":")[0])[name.split(":")[-1]] | |
| attr, *_, key = name.split(":") | |
| child_obj = getattr(parent, attr)[key] |
I think is a bit better and less nested
Comment on lines
130
to
134
There was a problem hiding this comment.
This shouldn't be required and it will mess with the type hints for the class, I've removed all of these in a separate PR
Comment on lines
51
to
52
There was a problem hiding this comment.
Would it be possible to add the type hint to the session_pure_meshing file here for a similar reason to my previous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.