Skip to content

fix: Updated field_info to handle deprecated warnings. #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Updated field_info to handle deprecated warnings. #4559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a762132
Fix: Updated field_info to handle deprecated warnings.
mayankansys Oct 16, 2025
bf34b57
chore: adding changelog file 4559.fixed.md [dependabot-skip]
pyansys-ci-bot Oct 16, 2025
1a07b95
Merge branch 'main' into fix/deprecation-warning-4513
mayankansys Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/4559.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Updated field_info to handle deprecated warnings.
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'deprecation warnings' instead of 'deprecated warnings' for correct terminology.

Suggested change
Updated field_info to handle deprecated warnings.
Updated field_info to handle deprecation warnings.

Copilot uses AI. Check for mistakes.
4 changes: 2 additions & 2 deletions src/ansys/fluent/core/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ def __init__(
)
self.field_data = service_creator("field_data").create(
_session._field_data_service,
self.field_info,
self._field_info,
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Swapping to the private _field_info likely avoids triggering the deprecation warning emitted by the public field_info accessor; consider adding a brief inline comment to document that intent for future maintainers.

Copilot uses AI. Check for mistakes.
self._is_solution_data_valid,
_session.scheme,
get_zones_info,
Expand All @@ -520,7 +520,7 @@ def __init__(
)
self.field_data_old = service_creator("field_data_old").create(
_session._field_data_service,
Comment on lines 521 to 522
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Same as line 513: add a short comment explaining use of the private _field_info to prevent internal deprecation noise.

Suggested change
self.field_data_old = service_creator("field_data_old").create(
_session._field_data_service,
# Use of the private _field_info prevents internal deprecation noise.
self.field_data_old = service_creator("field_data_old").create(

Copilot uses AI. Check for mistakes.
self.field_info,
self._field_info,
self._is_solution_data_valid,
_session.scheme,
)
Expand Down