ci: Fail the whole nightly job at the end if the testing step has failed [skip tests]

[mkundu1]

Context

The testing step has been marked with continue-on-error: true in the nightly testing CIs because we want to execute additional steps on failure (e.g. notify in Teams). Due to this the failure status is not being reported at the job level.

Change Summary

A final step has been added to set the job as failed if the testing step was failed before.

Rationale

We want to mark the job failed in a delayed manner, so that we can execute additional steps on failure. By default, a job retuns immediately from a failed step.

Impact

This change will correctly mark the failed job in GitHub.

[Copilot]

Pull Request Overview

This PR addresses an issue where nightly CI jobs were not being marked as failed when tests failed, due to the continue-on-error: true setting. A new final step has been added to explicitly fail the job if the testing step failed, allowing intermediate notification steps to execute first.

Key Changes

• Added a final step to check test outcomes and explicitly fail the job if tests failed
• Applied the change to both nightly testing workflows

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
doc/changelog.d/4564.maintenance.md	Added changelog entry documenting the CI fix
.github/workflows/test-run-dev-version-nightly.yml	Added final step to fail job if unittest step failed
.github/workflows/test-podman-compose.yml	Added final step to fail job if fluent_test step failed

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}