Skip to content

Conversation

@prmukherj
Copy link
Collaborator

Context

This particular 2d field data test was using the deprecated interface.

Change Summary

Updated the test to use new interface.

Impact

Only test is updated with no user facing code updates.

[1349379]

@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 11:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a 2D field data test to use the new interface for field data retrieval, replacing deprecated methods with the current API pattern. The changes maintain test functionality while modernizing the code to follow current best practices.

Key Changes:

  • Replaced direct get_scalar_field_data(), get_surface_data(), get_vector_field_data(), and get_pathlines_field_data() method calls with request-based pattern using get_field_data().
  • Updated data access patterns from dictionary-based to attribute-based access (e.g., .vertices, .face_centroids, .connectivity).

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@prmukherj prmukherj requested a review from millerj97 October 23, 2025 11:33
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants