Skip to content

chore: Update CI to include support for python 3.14#4987

Draft
prmukherj wants to merge 8 commits intomainfrom
chore/update_support_for_python_314
Draft

chore: Update CI to include support for python 3.14#4987
prmukherj wants to merge 8 commits intomainfrom
chore/update_support_for_python_314

Conversation

@prmukherj
Copy link
Collaborator

Context

PyFluent repo did not support Python 3.14

Change Summary

CI to include Python 3.14

event_loop.py was removed completely from utils and it's related docs have been updated.

Impact

Users will be able to use PyFluent with python 3.14

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD enhancement Improve any current implemented feature labels Mar 11, 2026
This was linked to issues Mar 11, 2026
{'x': 12, 'y': 42}
>>> on_case_loaded_with_args.state
{'x': 12, 'y': 42}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpearsonuk, this part of the user doc needs to be completely removed after removing the "event_loop"

Copy link
Collaborator

@seanpearsonuk seanpearsonuk Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prmukherj

Here are the options:

  1. Completely remove the example and event loop code, as you are currently doing.
  2. Keep the example code, and update the event loop code, according to the AI (or some other similar) suggestion.
  3. Keep the example code, and show the (updated) event loop code with it, given that the event loop code is not a PyFluent concern, but is needed to illustrate such examples.

The example is useful and execute_in_event_loop_threadsafe is playing an important part. Option 2 might be the lowest friction answer to this problem, even if the functions aren't core PyFluent business.

Option 3 is really more logical but incorporating the required code in the documentation makes integrating it more complicated thereby discourging its use.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should go with option 2 as well, although the point these 2 "functions aren't core PyFluent business" is lingering in my mind.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe see if AI can update the doc to incorporate all the code in an easily usable, robust form??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will see

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@github-actions github-actions bot added the dependencies Related to dependencies label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD dependencies Related to dependencies documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

event_loop module [MAINTENANCE] Support for Python 3.14

3 participants