chore: Update CI to include support for python 3.14#4987
chore: Update CI to include support for python 3.14#4987
Conversation
| {'x': 12, 'y': 42} | ||
| >>> on_case_loaded_with_args.state | ||
| {'x': 12, 'y': 42} | ||
|
|
There was a problem hiding this comment.
@seanpearsonuk, this part of the user doc needs to be completely removed after removing the "event_loop"
There was a problem hiding this comment.
Here are the options:
- Completely remove the example and event loop code, as you are currently doing.
- Keep the example code, and update the event loop code, according to the AI (or some other similar) suggestion.
- Keep the example code, and show the (updated) event loop code with it, given that the event loop code is not a PyFluent concern, but is needed to illustrate such examples.
The example is useful and execute_in_event_loop_threadsafe is playing an important part. Option 2 might be the lowest friction answer to this problem, even if the functions aren't core PyFluent business.
Option 3 is really more logical but incorporating the required code in the documentation makes integrating it more complicated thereby discourging its use.
There was a problem hiding this comment.
I agree that we should go with option 2 as well, although the point these 2 "functions aren't core PyFluent business" is lingering in my mind.
There was a problem hiding this comment.
Maybe see if AI can update the doc to incorporate all the code in an easily usable, robust form??
Context
PyFluent repo did not support Python 3.14
Change Summary
CI to include Python 3.14
event_loop.py was removed completely from utils and it's related docs have been updated.
Impact
Users will be able to use PyFluent with python 3.14