-
Notifications
You must be signed in to change notification settings - Fork 140
fix: documentation html looks #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR restores the navbar’s intended styling and layout by refining custom CSS rules to center elements and eliminate unwanted shadows, and by updating the Sphinx configuration to streamline sidebars and navbar items. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- In custom.css, the .sd-shadow-sm rule is missing a semicolon after the !important declaration—please add it to ensure proper parsing.
- The old html_sidebars and commented sidebar settings in conf.py should be removed or consolidated with the new secondary_sidebar_items configuration to avoid confusion.
- After removing the theme-specific CSS overrides, test both light and dark themes to confirm the navbar and other elements retain the intended styles consistently.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Related to: ansys/ansys-sphinx-theme#691 |
Asking sphinx/UI guys for a quick review @jorgepiloto @Revathyvenugopal162 |
…ion header formatting
Also related to: ansys/ansys-sphinx-theme#693 |
…ince it does not affect. Waiting for ansys-sphinx-theme release
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Latest release broke the navbar color.
Taking advantage of this PR and also do more stuff:
Edit on GitHub
link to the end of primary bar.Details
Navbar color
Centering navbar elements
Before
After
Moving search field to sidebar on small devices
Before
After
Removing secondary sidebar in all pages.
Before
After
Issue linked
Close #3914
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)