fix: mypy type checking issues across core modules

.ci/pytest_summary.py

@@ -79,15 +79,15 @@ def compute_statistics(
     test_stats: dict[str, TEST_STATS_TYPE] = {}
 
     for test in tests:
-        test_id: str = test["id"]
+        test_id = test["id"]  # type: ignore[assignment]
         if test_id not in test_stats:
-            test_stats[test_id] = {
+            test_stats[test_id] = {  # type: ignore[index]
                 "durations": [],
                 "n_tests": 0,
             }
 
-        test_stats[test_id]["durations"].append(test["duration"])
-        test_stats[test_id]["n_tests"] += 1
+        test_stats[test_id]["durations"].append(test["duration"])  # type: ignore[arg-type,index]
+        test_stats[test_id]["n_tests"] += 1  # type: ignore[index]
 
     summary: list[dict[str, Any]] = []
 
@@ -170,10 +170,10 @@ def make_bold(s: str) -> str:
         for i, each_key in enumerate(keys):
 
             if i == 0:
-                id_: str = test[each_key]
+                id_ = test[each_key]  # type: ignore[assignment]
 
                 id_ = (
-                    id_.replace("(", r"(")
+                    id_.replace("(", r"(")  # type: ignore[union-attr]
                     .replace(")", r")")
                     .replace("[", r"[")
                     .replace("]", r"]")
@@ -197,8 +197,8 @@ def make_bold(s: str) -> str:
 
 def print_summary(summary: list[dict[str, str | float]], num: int = 10):
     """Print the top N longest tests and the top N most variable tests."""
-    longest_tests = sorted(summary, key=lambda x: -x["average_duration"])[:num]
-    most_variable_tests = sorted(summary, key=lambda x: -x["std_dev"])[:num]
+    longest_tests = sorted(summary, key=lambda x: -x["average_duration"])[:num]  # type: ignore[operator]
+    most_variable_tests = sorted(summary, key=lambda x: -x["std_dev"])[:num]  # type: ignore[operator]
 
     print(f"\n## Top {num} Longest Running Tests\n")
     print_table(

.github/workflows/migrator.yml

@@ -298,7 +298,7 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0
         with:
           ref: main
-          persist-credentials: true
+          persist-credentials: true # zizmor: ignore[artipacked]
 
       - name: Clone head repo and checkout branch. Resolve conflicts if needed.
         if : ${{ env.CONTINUE == 'true' }}

.pre-commit-config.yaml

@@ -9,7 +9,6 @@ ci:
 
   # PR name when autoupdate
   autoupdate_commit_msg: 'ci: pre-commit autoupdate'
-  skip: [mypy]
 
 
 repos:
@@ -24,6 +23,7 @@ repos:
   hooks:
     - id: mypy
       args: [ --follow-imports=silent, --config-file=pyproject.toml]
+      exclude: ^(doc/|examples/)
 
 - repo: https://github.com/ansys/pre-commit-hooks
   rev: v0.5.2

doc/changelog.d/4309.fixed.md

@@ -0,0 +1 @@
+Mypy type checking issues across core modules

examples/00-mapdl-examples/bracket_static.py

@@ -68,7 +68,7 @@
 ~~~~~~~~~~~~~
 
 The dimensions of the corner bracket are shown in the following figure.
-The bracket is made of A36 steel with a Young's modulus of :math:`3\cdot 10^7` psi
+The bracket is made of A36 steel with a Young's modulus of :math:`3\\cdot 10^7` psi
 and Poisson's ratio of :math:`0.27`.
 
 .. figure:: ../../../images/bracket_dimensions.png

pyproject.toml

@@ -274,6 +274,18 @@ disable_error_code = [
   "return",
   "return-value",
 ]
+exclude = [
+  "^\\.ci/",
+  "^build/",
+  "^dist/",
+  "^doc/",
+  "^examples/",
+  "^htmlcov/",
+  "^tests/",
+]
+explicit_package_bases = true
+namespace_packages = true
+
 
 [tool.towncrier]
 directory = "doc/changelog.d"

src/ansys/mapdl/core/_commands/__init__.py

@@ -19,3 +19,46 @@
 # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
+
+from typing import Any, Optional
+
+
+class CommandsBase:
+    """Base class for MAPDL command mixin classes.
+
+    This class declares the interface that command mixin classes rely on.
+    The actual implementation of the run method is provided by the parent
+    MAPDL class when these command mixins are combined via multiple inheritance.
+    """
+
+    def run(
+        self,
+        command: str,
+        write_to_log: bool = True,
+        mute: Optional[bool] = None,
+        **kwargs: Any,
+    ) -> str:
+        """Run a single APDL command.
+
+        This method is implemented by the parent MAPDL class.
+        Command mixins can call this method to execute APDL commands.
+
+        Parameters
+        ----------
+        command : str
+            ANSYS APDL command.
+        write_to_log : bool, optional
+            Whether to write command to log. Default ``True``.
+        mute : bool, optional
+            Whether to mute command output.
+        **kwargs : Any
+            Additional keyword arguments.
+
+        Returns
+        -------
+        str
+            Command output from MAPDL.
+        """
+        raise NotImplementedError(
+            "The run method must be provided by the parent MAPDL class"
+        )

src/ansys/mapdl/core/_commands/apdl/abbreviations.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Abbreviations:
+
+class Abbreviations(CommandsBase):
 
     def abbr(self, abbr: str = "", string: str = "", **kwargs):
         r"""Defines an abbreviation.

src/ansys/mapdl/core/_commands/apdl/array_parameters.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class ArrayParameters:
+
+class ArrayParameters(CommandsBase):
 
     def mfouri(
         self,

src/ansys/mapdl/core/_commands/apdl/encryption_decryption.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class EncryptionDecryption:
+
+class EncryptionDecryption(CommandsBase):
 
     def dbdecrypt(
         self,

src/ansys/mapdl/core/_commands/apdl/macro_files.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class MacroFiles:
+
+class MacroFiles(CommandsBase):
 
     def cfclos(self, **kwargs):
         r"""Closes the "command" file.

src/ansys/mapdl/core/_commands/apdl/matrix_operations.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class MatrixOperations:
+
+class MatrixOperations(CommandsBase):
 
     def axpy(
         self,

src/ansys/mapdl/core/_commands/apdl/parameter_definition.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class ParameterDefinition:
+
+class ParameterDefinition(CommandsBase):
 
     def afun(self, lab: str = "", **kwargs):
         r"""Specifies units for angular functions in parameter expressions.

src/ansys/mapdl/core/_commands/apdl/process_controls.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class ProcessControls:
+
+class ProcessControls(CommandsBase):
 
     def starexit(self, **kwargs):
         r"""Exits a do-loop.

src/ansys/mapdl/core/_commands/aux12/general_radiation.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class GeneralRadiation:
+
+class GeneralRadiation(CommandsBase):
 
     def aux12(self, **kwargs):
         r"""Enters the radiation processor.

src/ansys/mapdl/core/_commands/aux12/radiation_matrix_method.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class RadiationMatrixMethod:
+
+class RadiationMatrixMethod(CommandsBase):
 
     def emis(self, mat: str = "", evalu: str = "", **kwargs):
         r"""Specifies emissivity as a material property for the Radiation Matrix method.

src/ansys/mapdl/core/_commands/aux12/radiosity_solver.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class RadiositySolver:
+
+class RadiositySolver(CommandsBase):
 
     def vfco(self, action: str = "", encl: str = "", level: int | str = "", **kwargs):
         r"""Controls the use and level of view factor condensation for symmetric radiation.

src/ansys/mapdl/core/_commands/aux15/iges.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Iges:
+
+class Iges(CommandsBase):
 
     def aux15(self, **kwargs):
         r"""Enters the IGES file transfer processor.

src/ansys/mapdl/core/_commands/aux2/binary_file_dump.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class BinaryFileDump:
+
+class BinaryFileDump(CommandsBase):
 
     def aux2(self, **kwargs):
         r"""Enters the binary file dumping processor.

src/ansys/mapdl/core/_commands/aux2/binary_file_manipulation.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class BinaryFileManipulation:
+
+class BinaryFileManipulation(CommandsBase):
 
     def combine(self, filetype: str = "", num: str = "", **kwargs):
         r"""Combines distributed memory parallel ( DMP ) files.

src/ansys/mapdl/core/_commands/aux3/results_files.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class ResultsFiles:
+
+class ResultsFiles(CommandsBase):
 
     def aux3(self, **kwargs):
         r"""Enters the results file editing processor.

src/ansys/mapdl/core/_commands/conn.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Conn:
+
+class Conn(CommandsBase):
     def cat5in(
         self,
         name="",

src/ansys/mapdl/core/_commands/database/components.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Components:
+
+class Components(CommandsBase):
 
     def cm(self, cname: str = "", entity: str = "", kopt: str = "", **kwargs):
         r"""Groups geometry items into a component.

src/ansys/mapdl/core/_commands/database/coordinate_system.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class CoordinateSystem:
+
+class CoordinateSystem(CommandsBase):
 
     def clocal(
         self,

src/ansys/mapdl/core/_commands/database/picking.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Picking:
+
+class Picking(CommandsBase):
 
     def fitem(
         self,

src/ansys/mapdl/core/_commands/database/selecting.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class Selecting:
+
+class Selecting(CommandsBase):
 
     def allsel(self, labt: str = "", entity: str = "", **kwargs):
         r"""Selects all entities with a single command.

src/ansys/mapdl/core/_commands/database/set_up.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class SetUp:
+
+class SetUp(CommandsBase):
 
     def clear(self, read: str = "", **kwargs):
         r"""Clears the database.

src/ansys/mapdl/core/_commands/database/working_plane.py

@@ -20,8 +20,10 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
+from ansys.mapdl.core._commands import CommandsBase
 
-class WorkingPlane:
+
+class WorkingPlane(CommandsBase):
 
     def kwpave(
         self,