Skip to content

Conversation

@dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Jan 30, 2026

added mypy pre-commit and fixed all issues with type hints

@dipinknair dipinknair requested a review from a team as a code owner January 30, 2026 20:32
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Jan 30, 2026
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 30, 2026
@codacy-production
Copy link

codacy-production bot commented Jan 30, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.76% (target: -1.00%) 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bc2e960) 3109 2545 81.86%
Head commit (bf09c39) 3122 (+13) 2532 (-13) 81.10% (-0.76%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1502) 60 50 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (bc2e960) to head (bf09c39).

❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
- Coverage   81.18%   81.10%   -0.09%     
==========================================
  Files          42       42              
  Lines        3109     3122      +13     
==========================================
+ Hits         2524     2532       +8     
- Misses        585      590       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

The documentation for this pull request will be available at https://mechanical.docs.pyansys.com/pull/1502. Please allow some time for the documentation to be deployed.

@dipinknair dipinknair requested a review from klmcadams January 30, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants