Skip to content

Conversation

@krishnatejas12
Copy link
Collaborator

New cht example for a pipe flow problem added.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 6, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.21%. Comparing base (bec6362) to head (86df3c6).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   85.77%   85.21%   -0.56%     
==========================================
  Files          43       43              
  Lines        2679     2686       +7     
==========================================
- Hits         2298     2289       -9     
- Misses        381      397      +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

-----------------------------------

This example illustrates a two way conjugate heat transfer case for
*flow in a pipe* that is used as a tutorial for System Coupling. This Fluid-Structure
Copy link

@dabrown93 dabrown93 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using System Coupling" intead of "that is used as a tutorial for System Coupling". Then it says "This Fluid-Structure interaction... " etc. You can delete that sentence. You can write more about the case. How about this:
"Conjugate heat transfer problems can be numerically unstable. This example demonstrates how a user may appropraitely choose interface conditions and stabilization scheme for this configuration."

- Ansys Mechanical APDL (MAPDL) is used to perform a structural analysis.
- Ansys Fluent is used to perform a steady fluid-flow analysis.
- System Coupling coordinates the coupled sloution involving the above products to
solve the multiphysics problem via co-simulation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the following:

  • Ansys Fluent is used to model the thermal fluid flow in the pipe
  • Ansys Mechanical APDL (MAPDL) is used to model thermal transfer in the pipe wall.
  • System Coupling coordinates the coupled solution to the conjugate heat transfer problem, including numerical stabilization if needed.



The flow is smooth inside the pipe and the outer wall of the pipe is adiabatic. Fluid enters
at an initial temperature of 300K while the outside pipe of the wall is at 400K.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outer wall is 350K.


The flow is smooth inside the pipe and the outer wall of the pipe is adiabatic. Fluid enters
at an initial temperature of 300K while the outside pipe of the wall is at 400K.
The setup is simulated for a few iterations to allow the examination

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this line:
"The setup is simulated for a few..." etc.

#
# Perform required imports
# ~~~~~~~~~~~~~~~~~~~~~~~~
# Import ``ansys-systemcoupling-core``, ``ansys-fluent-core``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ansys-mapdl-core.


# %%
# Set up 2-way thermal FSI coupling
syc.setup.add_thermal_data_transfers(interface=interface_name)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this, it might be better to manually add the transfers, and explain that it is better to send heat rate to the solid.

# %%
# Set up 2-way thermal FSI coupling
syc.setup.add_thermal_data_transfers(interface=interface_name)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be good place for the Biot number calculation, and we want to give some comment about it. "Check the Biot number, and apply stabilization if the Biot number is large." You can also include some code:
if Bi > 1:
syc.setup.analysis_control.global_stabilization = "Quasi-Newton"

Nu = 0.023 * Re**0.8 * Pr**0.4
h = Nu * k_f / L_c
Bi = h * L_c / k_s
return Bi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need comments for all lines of this function. Like "Calculate the Reynolds number based on the pipe length." "Calculate Nusselt number for laminar pipe flow based on [cite reference]." "Calculate the convection coefficient of the fluid based on the fluid Nusselt number." "Calculate the Biot number for the pipe flow based on [cite reference]."



# %%
# Biot number prediction

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can document this function more. Define each input and the return value.

# Exit
# ----
syc.end_output()
syc.exit()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets include some visualization. We can include both the mesh and the results, at the appropriate point in the code.

return Bi


Bi = biot_number()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Biot number calculation can move down to the System Coupling setup.


# %%
# Creating the regions from the geometry for named selections
# Inner wall NS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is NS? Lets include more detailed comments in this section so users can understand what is happening.

dependabot bot and others added 6 commits November 26, 2025 15:02
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@634f93c...018cc2c)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
Bumps [ansys/actions](https://github.com/ansys/actions) from 10.1.4 to 10.1.5.
- [Release notes](https://github.com/ansys/actions/releases)
- [Changelog](https://github.com/ansys/actions/blob/main/CHANGELOG.md)
- [Commits](ansys/actions@c2fa7c9...21c9de9)

---
updated-dependencies:
- dependency-name: ansys/actions
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
Bumps [ansys-mapdl-core](https://github.com/ansys/pymapdl) from 0.71.0 to 0.71.1.
- [Release notes](https://github.com/ansys/pymapdl/releases)
- [Changelog](https://github.com/ansys/pymapdl/blob/main/CHANGELOG.md)
- [Commits](ansys/pymapdl@v0.71.0...v0.71.1)

---
updated-dependencies:
- dependency-name: ansys-mapdl-core
  dependency-version: 0.71.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
Bumps [pypandoc](https://github.com/JessicaTegner/pypandoc) from 1.15 to 1.16.2.
- [Release notes](https://github.com/JessicaTegner/pypandoc/releases)
- [Changelog](https://github.com/JessicaTegner/pypandoc/blob/master/release.md)
- [Commits](JessicaTegner/pypandoc@v1.15...v1.16.2)

---
updated-dependencies:
- dependency-name: pypandoc
  dependency-version: 1.16.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@6da8fa9...5be0e66)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-version: 2.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
* Bump black from 25.9.0 to 25.11.0

Bumps [black](https://github.com/psf/black) from 25.9.0 to 25.11.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@25.9.0...25.11.0)

---
updated-dependencies:
- dependency-name: black
  dependency-version: 25.11.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* sync black update to pre-commit config

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
iboyd-ansys and others added 6 commits November 26, 2025 15:02
* ci: proper environment set up for releasing

* Fix typo

---------

Co-authored-by: Ian Boyd <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@08c6903...93cb6ef)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@93cb6ef...1af3b93)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.0.0 to 6.1.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@e797f83...83679a8)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@github-actions github-actions bot added dependencies Related to project dependencies maintenance Package and maintenance related CI/CD Related to CICD, Github Actions, etc labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CICD, Github Actions, etc dependencies Related to project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants