Skip to content

Updated formulation for Biot number calculation #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krishnatejas12 wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Updated formulation for Biot number calculation #586

krishnatejas12 wants to merge 15 commits into from

Conversation

@krishnatejas12
Copy link
Collaborator

@krishnatejas12 krishnatejas12 commented Jan 21, 2026

Updated code to use respective formulas for Nusselt number calculation for laminar and turbulent flow

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 21, 2026
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
iboyd-ansys and others added 9 commits January 21, 2026 17:07
@iboyd-ansys
fix: add explicit units lib dependency (#585)
401f4d2 
Add explicit units lib dependency
@dependabot @iboyd-ansys
build(deps): bump actions/download-artifact from 6.0.0 to 7.0.0 (#579)
0bbe17c 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@018cc2c...37930b1)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@dependabot @iboyd-ansys
build(deps): bump actions/upload-artifact from 5.0.0 to 6.0.0 (#580)
ac4e7ab 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@330a01c...b7c566a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@dependabot @iboyd-ansys
build(deps-dev): bump sphinxemoji from 0.3.1 to 0.3.2 (#581)
0e65d0c 
Bumps [sphinxemoji](https://github.com/sphinx-contrib/emojicodes) from 0.3.1 to 0.3.2.
- [Commits](sphinx-contrib/emojicodes@v0.3.1...v0.3.2)

---
updated-dependencies:
- dependency-name: sphinxemoji
  dependency-version: 0.3.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@iboyd-ansys @krishnatejas12
fix: add explicit units lib dependency (#585)
1b79b4d 
Add explicit units lib dependency
@dependabot @iboyd-ansys @krishnatejas12
build(deps): bump actions/download-artifact from 6.0.0 to 7.0.0 (#579)
f99cc1d 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@018cc2c...37930b1)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@dependabot @iboyd-ansys @krishnatejas12
build(deps): bump actions/upload-artifact from 5.0.0 to 6.0.0 (#580)
2c33c49 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@330a01c...b7c566a)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@dependabot @iboyd-ansys @krishnatejas12
build(deps-dev): bump sphinxemoji from 0.3.1 to 0.3.2 (#581)
6f0f02d 
Bumps [sphinxemoji](https://github.com/sphinx-contrib/emojicodes) from 0.3.1 to 0.3.2.
- [Commits](sphinx-contrib/emojicodes@v0.3.1...v0.3.2)

---
updated-dependencies:
- dependency-name: sphinxemoji
  dependency-version: 0.3.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Boyd <[email protected]>
@krishnatejas12
addressed changes to be made after review
aa97e8b
@github-actions github-actions bot added dependencies Related to project dependencies maintenance Package and maintenance related CI/CD Related to CICD, Github Actions, etc labels Jan 21, 2026
dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
examples/00-systemcoupling/cht_pipe.py Outdated
print(f"Nusselt Number ={Nu}")
print(f"Heat Transfer Coefficient={h}")
print(f"Biot number= {Bi}")
print(f"Nusselt number correlation used= {corr}")
Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spacings around equal signs here. It should be one space on each side.

dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
examples/00-systemcoupling/cht_pipe.py Outdated
def nusselt_number(Re, Pr, n):
"""Dittus–Boelter Nusselt number."""
return 0.023 * (Re**0.8) * (Pr**n)
def nusselt_dittus_boelter(
Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the Dittus-Boelter equation anymore though right. Also I think it can be preferable to have a single functionfor the Nusselt number with the logic inside. I think I left another comment about that earlier.

dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
examples/00-systemcoupling/cht_pipe.py Outdated
):
# Formulation from: # Bergman, T. L., Lavine, A. S.,
# Incropera, F. P., & DeWitt, D. P. (2017).
# Fundamentals of heat and mass transfer (8th ed.). Wiley.
Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital letters "Heat and Mass Transfer"

dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
examples/00-systemcoupling/cht_pipe.py Outdated
Re,
Pr,
):
# Formulation from: # Bergman, T. L., Lavine, A. S.,
Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "#" is not needed in the middle of a line.

Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, maybe just "From" instead of "Formulation from".

dabrown93
dabrown93 reviewed Jan 21, 2026
View reviewed changes
.github/workflows/ci.yml

- name: Download package
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
Copy link

@dabrown93 dabrown93 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these changed? Maybe try pulling the main branch and rebasing on it to see if they go away.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.43%. Comparing base (b882f04) to head (aa97e8b).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   81.42%   81.43%           
=======================================
  Files          44       44           
  Lines        2983     2984    +1     
=======================================
+ Hits         2429     2430    +1     
  Misses        554      554
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ochernuk ochernuk ochernuk approved these changes

+1 more reviewer

@dabrown93 dabrown93 dabrown93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Related to CICD, Github Actions, etc dependencies Related to project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@krishnatejas12 @codecov-commenter @ochernuk @dabrown93 @iboyd-ansys