-
Notifications
You must be signed in to change notification settings - Fork 2.5k
refactor: f2elint #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: f2elint #6861
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
ci 挂了,要处理一下。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the linting toolchain by switching to f2elint for integrating ESLint, Stylelint, Prettier, Commitlint, and Husky. It removes all legacy configuration files and introduces a new ESLint configuration.
Reviewed Changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
eslint.config.mjs | New ESLint configuration integrating react and prettier configs via f2elint |
commitlint.config.js | Legacy commitlint configuration removed |
.stylelintrc.js | Legacy stylelint configuration removed |
.prettierrc.js | Legacy prettier configuration removed |
.eslintrc.js | Legacy ESLint configuration removed |
Files not reviewed (6)
- .editorconfig: Language not supported
- .eslintignore: Language not supported
- .husky/commit-msg: Language not supported
- .husky/pre-commit: Language not supported
- .vscode/settings.json: Language not supported
- package.json: Language not supported
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6861 +/- ##
==========================================
- Coverage 92.76% 92.76% -0.01%
==========================================
Files 336 336
Lines 7214 7211 -3
Branches 1799 1807 +8
==========================================
- Hits 6692 6689 -3
- Misses 486 514 +28
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
gulpfile.js
Outdated
const packageJson = require('./package.json') | ||
const StatoscopeWebpackPlugin = require('@statoscope/webpack-plugin').default | ||
const pxMultiplePlugin = require('postcss-px-multiple')({ times: 2 }) | ||
const gulp = require('gulp'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我不太建议改分号规则,这样 blame 全部会指这个 PR。或者可以考虑配置只格式化提交的文件。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已去除分号和逗号规则,Diff 行数从 37K 减少到了 19K
使用 f2elint 工具接入最新的 ESLint, Stylelint, Prettier, Commitlint, Husky 工具链