Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Feb 7, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

react-component/tabs#775

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Improve Tabs accessibility by fixing error Certain ARIA roles must contain particular children.
🇨🇳 Chinese 优化 Tabs 组件的可访问性,修复 Certain ARIA roles must contain particular children 的报错。

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2025

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 775110f
Status: ✅  Deploy successful!
Preview URL: https://ad9eb8e8.ant-design.pages.dev
Branch Preview URL: https://chore-upgrade-tabs.ant-design.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👁 Visual Regression Report for PR #52677 Failed ❌

🎯 Target branch: master (36c308c)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Preview is ready

@petercat-assistant
Copy link

Walkthrough

This pull request enhances the accessibility of the Tabs component by addressing an ARIA role compliance issue. The update ensures that specific ARIA roles contain the required children, improving the component's usability for assistive technologies.

Changes

Files Summary
components/card/tests/snapshots/demo-extend.test.ts.snap, components/card/tests/snapshots/demo.test.ts.snap Minor snapshot updates with 6 changes each.
components/card/tests/snapshots/index.test.tsx.snap Snapshot update with 4 changes.
components/config-provider/tests/snapshots/components.test.tsx.snap Snapshot update with 14 changes.
components/splitter/tests/snapshots/demo-extend.test.ts.snap, components/splitter/tests/snapshots/demo.test.ts.snap Minor snapshot updates with 2 changes each.
components/tabs/tests/snapshots/demo-extend.test.ts.snap, components/tabs/tests/snapshots/demo.test.ts.snap Significant snapshot updates with 61 and 63 changes respectively.
components/tabs/tests/snapshots/index.test.tsx.snap Snapshot update with 8 changes.
package.json Updated rc-tabs dependency version from ~15.5.0 to ~15.5.1.

"rc-switch": "~4.1.0",
"rc-table": "~7.50.2",
"rc-tabs": "~15.5.0",
"rc-tabs": "~15.5.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update of rc-tabs from version ~15.5.0 to ~15.5.1 should be verified to ensure it resolves the ARIA role compliance issue without introducing new issues. Please ensure that all related components are tested for compatibility.

@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ant-design/[email protected] None 0 32.7 kB afc163
npm/@ant-design/[email protected] environment 0 390 kB afc163
npm/@ant-design/[email protected] environment 0 92 kB yumoimer
npm/@ant-design/[email protected] environment 0 290 kB zombiej
npm/@ant-design/[email protected] None 0 43.9 kB zombiej
npm/@ant-design/[email protected] None 0 30.9 kB zombiej
npm/@ant-design/[email protected] environment 0 8.77 MB zombiej
npm/@ant-design/[email protected] environment 0 832 kB afc163
npm/@ant-design/[email protected] filesystem 0 66.5 kB zombiej
npm/@ant-design/[email protected] None 0 9.33 kB zombiej
npm/@antfu/[email protected] environment 0 825 kB antfu
npm/@antv/[email protected] None 0 7.99 MB iaaron
npm/@biomejs/[email protected] shell 0 210 kB dominionl
npm/@codecov/[email protected] None 0 65.3 kB codecov-devops
npm/@codesandbox/[email protected] None 0 1.21 MB alexnm, christianalfoni, compuives, ...1 more
npm/@dnd-kit/[email protected] environment 0 1.07 MB clauderic
npm/@dnd-kit/[email protected] environment 0 49 kB clauderic
npm/@dnd-kit/[email protected] environment 0 234 kB clauderic
npm/@dnd-kit/[email protected] environment 0 88.5 kB clauderic
npm/@emotion/[email protected] None 0 273 kB emotion-release-bot
npm/@emotion/[email protected] environment 0 48.7 kB emotion-release-bot
npm/@eslint-react/[email protected] None 0 306 kB rel1cx
npm/@ianvs/[email protected] environment, unsafe 0 115 kB ianvs
npm/@inquirer/[email protected] None 0 23.9 kB sboudrias
npm/@madccc/[email protected] None 0 19 kB madccc
npm/@microflash/[email protected] None 0 6.71 kB naiyer
npm/@npmcli/[email protected] environment 0 18.3 kB npm-cli-ops
npm/@octokit/[email protected] None 0 8.28 kB gr2m, kfcampbell, nickfloyd, ...1 more
npm/@qixian.cs/[email protected] network 0 19.6 kB chenshuai2144
npm/@rc-component/[email protected] environment 0 83.1 kB afc163
npm/@rc-component/[email protected] environment 0 16.7 kB zombiej
npm/@rc-component/[email protected] None 0 146 kB zombiej
npm/@rc-component/[email protected] None 0 68.3 kB afc163
npm/@rc-component/[email protected] environment 0 184 kB zombiej
npm/@size-limit/[email protected] None 0 3.43 kB ai
npm/@stackblitz/[email protected] None 0 186 kB tsulkowski
npm/@testing-library/[email protected] environment 0 2.43 MB testing-library-bot
npm/@testing-library/[email protected] None 0 282 kB testing-library-bot
npm/@testing-library/[email protected] None 0 337 kB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@testing-library/[email protected] None 0 438 kB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@types/[email protected] None 0 24.6 kB types
npm/@types/[email protected] None 0 42.2 kB types
npm/@types/[email protected] None 0 13.1 kB types
npm/@types/[email protected] None 0 36.8 kB types
npm/@types/[email protected] None 0 9.1 kB types
npm/@types/[email protected] None 0 4.58 kB types
npm/@types/[email protected] None 0 2.77 kB types
npm/@types/[email protected] None 0 6.62 kB types
npm/@types/[email protected] None 0 6.09 kB types
npm/@types/[email protected] None 0 9.68 kB types
npm/@types/[email protected] None 0 78.8 kB types
npm/@types/[email protected] None 0 1.12 MB types
npm/@types/[email protected] None 0 21.9 kB types
npm/@types/[email protected] None 0 868 kB types
npm/@types/[email protected] None 0 6.27 kB types
npm/@types/[email protected] None 0 2.31 MB types
npm/@types/[email protected] None 0 4.83 kB types
npm/@types/[email protected] None 0 7.87 kB types
npm/@types/[email protected] None 0 5.47 kB types
npm/@types/[email protected] None 0 19.4 kB types
npm/@types/[email protected] None 0 6.51 kB types
npm/@types/[email protected] None 0 7.46 kB types
npm/@types/[email protected] None 0 4.36 kB types
npm/@types/[email protected] None 0 20.6 kB types
npm/@types/[email protected] None 0 5.75 kB types
npm/@types/[email protected] None 0 7.36 kB types
npm/@types/[email protected] None 0 800 kB types
npm/@types/[email protected] None 0 23.3 kB types
npm/@types/[email protected] None 0 8.22 kB types
npm/@types/[email protected] None 0 30.8 kB types
npm/@types/[email protected] None 0 6.48 kB types
npm/@types/[email protected] None 0 2.71 kB types
npm/[email protected] filesystem 0 121 kB cthackers
npm/[email protected] filesystem 0 2.74 MB fengmk2
npm/[email protected] None 0 47.9 kB nanxiaobei
npm/[email protected] environment 0 191 kB arvinxx
npm/[email protected] None 0 1.22 MB madccc
npm/[email protected] network 0 2.13 MB jasonsaayman
npm/[email protected] None 0 44.2 kB sindresorhus
npm/[email protected] None 0 1.25 MB feedic
npm/[email protected] None 0 10.5 kB theron
npm/[email protected] None 0 62.2 kB andidittrich
npm/[email protected] environment 0 29.1 kB kentcdodds
npm/[email protected] network 0 93.3 kB lquixada
npm/[email protected] filesystem 0 8.91 kB benjycui
npm/[email protected] environment, filesystem 0 75.8 kB motdotla
npm/[email protected] None 0 38.7 kB wxh16144
npm/[email protected] environment, eval, filesystem 0 2.92 MB yifankakaxi
npm/[email protected] None 0 9.81 kB sindresorhus
npm/[email protected] filesystem +1 202 kB amilajack
npm/[email protected] None 0 350 kB aaronabramov, jeysal, jsonp, ...6 more
npm/[email protected] None 0 753 kB ljharb
npm/[email protected] environment 0 180 kB react-bot
npm/[email protected] None 0 18.1 kB arnaud-barre
npm/[email protected] None 0 3.38 MB eslintbot, openjsfoundation
npm/[email protected] None 0 12.4 kB camsong
npm/[email protected] environment 0 180 kB zombiej
npm/[email protected] None 0 20.5 kB zombiej
npm/[email protected] None 0 52.4 kB afc163
npm/[email protected] environment 0 77.4 kB afc163
npm/[email protected] environment 0 59.6 kB zombiej
npm/[email protected] None 0 43.1 kB zombiej
npm/[email protected] environment 0 292 kB zombiej
npm/[email protected] environment 0 159 kB afc163
npm/[email protected] None 0 81.5 kB afc163, madccc, paranoidjk, ...5 more
npm/[email protected] None 0 73.8 kB afc163, madccc, zombiej
npm/[email protected] None 0 78.5 kB afc163, madccc, zombiej
npm/[email protected] environment 0 256 kB zombiej
npm/[email protected] None 0 107 kB 07akioni, afc163, madccc, ...1 more
npm/[email protected] environment 0 88.3 kB madccc
npm/[email protected] environment 0 166 kB zombiej
npm/[email protected] None 0 907 kB 07akioni, afc163, lixuan, ...3 more
npm/[email protected] environment 0 52.3 kB afc163
npm/[email protected] None 0 40.6 kB madccc
npm/[email protected] environment 0 36.5 kB afc163
npm/[email protected] environment 0 50.3 kB afc163
npm/[email protected] None 0 347 kB afc163, chenshuai2144, madccc, ...6 more
npm/[email protected] None 0 173 kB afc163, benjycui, jljsj33, ...6 more
npm/[email protected] None 0 48.3 kB zombiej
npm/[email protected] None 0 20.5 kB afc163
npm/[email protected] environment 0 404 kB zombiej
npm/[email protected] None 0 175 kB afc163, benjycui, madccc, ...4 more
npm/[email protected] None 0 63.5 kB afc163, lixuan, madccc, ...1 more
npm/[email protected] None 0 55.2 kB zombiej
npm/[email protected] environment 0 179 kB zombiej
npm/[email protected] None 0 359 kB zombiej
npm/[email protected] None 0 80.3 kB afc163
npm/[email protected] Transitive: environment +1 267 kB afc163
npm/[email protected] None 0 0 B
npm/[email protected] None 0 44.8 kB stipsan
npm/[email protected] 🔁 npm/[email protected] None 0 68.6 kB niksy

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size
dist/antd.min.js 441.72 KB
dist/antd-with-locales.min.js 509.96 KB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 7, 2025

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (36c308c) to head (775110f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #52677   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13781     13781           
  Branches      3610      3610           
=========================================
  Hits         13781     13781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 755cde5 into master Feb 7, 2025
44 checks passed
@afc163 afc163 deleted the chore/upgrade-tabs branch February 7, 2025 03:50
@MadCcc MadCcc mentioned this pull request Feb 10, 2025
16 tasks
renny-ren pushed a commit to renny-ren/ant-design that referenced this pull request Apr 14, 2025
* chore: bump rc-tabs

* chore: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants