-
-
Notifications
You must be signed in to change notification settings - Fork 998
fix(XMarkdown): export StreamCacheTokenType type from XMarkdown interface #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(XMarkdown): export StreamCacheTokenType type from XMarkdown interface #1592
Conversation
📝 Walkthrough功能概览在 变更内容
估计代码审查工作量🎯 1 (Trivial) | ⏱️ ~3 minutes 诗歌
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Last-Order, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a type visibility issue within the XMarkdown component by exporting the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces the export of a new type, StreamCacheTokenType, from packages/x-markdown/src/index.ts. There are no review comments provided for these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a TypeScript type export issue by adding StreamCacheTokenType to the public API exports. The StreamCacheTokenType enum is required by consumers who need to properly type their incompleteMarkdownComponentMap configuration, as this property uses StreamCacheTokenType in its type definition.
- Export
StreamCacheTokenTypeenum from the main package entry point to make it available to external consumers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 140 140
Lines 4245 4245
Branches 1203 1184 -19
=======================================
Hits 4026 4026
Misses 217 217
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportBundle size has no change ✅ |

中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
StreamingOption["incompleteMarkdownComponentMap"]requiresRecord<Exclude<(typeof StreamCacheTokenType)[keyof typeof StreamCacheTokenType], 'text'>,string>so we should exportStreamCacheTokenType。📝 Change Log
StreamCacheTokenTypeto supportincompleteMarkdownComponentMap.StreamCacheTokenType以支持incompleteMarkdownComponentMap。Summary by CodeRabbit
发布说明
✏️ Tip: You can customize this high-level summary in your review settings.