Skip to content

Conversation

@Haustle-v
Copy link

@Haustle-v Haustle-v commented Dec 9, 2025

Why are these changes needed?

The community has asked whether AntRay provides a prebuilt Docker image. Currently, there is no official prebuilt image published. This PR addresses the request by providing a ready-to-use docker image for AntRay development, following the build-docker-ant.sh, and is available from the Alibaba Docker Registry.

Related issue number

#603

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Summary by Sourcery

Documentation:

  • Add a reference in the Docker build script comments to a pre-built AntRay image hosted on Alibaba Cloud Container Registry.

liying919 and others added 2 commits December 1, 2025 17:09
* [RuntimeEnv] Support custom podman command

* Fix empty env keys

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* fix

* fix

* Add test for output filter

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 9, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a comment to the Ant Ray Docker build script documenting the availability and location of a prebuilt Ant Ray Docker image in Alibaba Cloud Container Registry for users who do not want to build the image locally.

File-Level Changes

Change Details Files
Document availability of a prebuilt Ant Ray Docker image in Alibaba Cloud Container Registry within the local build script.
  • Add a comment explaining that a prebuilt Ant Ray image exists as an example aligned with the existing build script.
  • Provide the full image name and registry path so users can pull the prebuilt image directly instead of building it themselves.
build-docker-ant.sh

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link

Summary of Changes

Hello @Haustle-v, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the availability of a pre-built Docker image for AntRay development. This change aims to simplify the development environment setup for users by providing a ready-to-use image, directly addressing a common community request. The image is accessible via the Alibaba Cloud Container Registry.

Highlights

  • Pre-built Docker Image: An example of a pre-built AntRay Docker image is now available to address community requests for easier setup.
  • Image Location: The pre-built Docker image is hosted on the Alibaba Cloud Container Registry for convenient access.
  • Build Process: The provided image is constructed following the existing build-docker-ant.sh script, ensuring consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider clarifying in the comment whether this Alibaba Cloud Container Registry image is official/supported and who maintains it, so users understand its status and longevity.
  • Hard-coding a personal ACR namespace in the script comment may become stale or misleading over time; you might generalize the example (e.g., placeholder URI) and point to a canonical location (README or docs) for up-to-date image references instead.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider clarifying in the comment whether this Alibaba Cloud Container Registry image is official/supported and who maintains it, so users understand its status and longevity.
- Hard-coding a personal ACR namespace in the script comment may become stale or misleading over time; you might generalize the example (e.g., placeholder URI) and point to a canonical location (README or docs) for up-to-date image references instead.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comment to build-docker-ant.sh pointing to a pre-built Docker image for AntRay, which is a helpful addition for developers. My feedback focuses on improving the clarity of this comment. I've suggested making it explicit that the image is unofficial and hosted on a personal registry to manage user expectations about its official support and long-term stability.

Comment on lines +5 to +6
# A pre-built image example, constructed following build-docker-ant.sh, is available on Alibaba Cloud Container Registry:
# crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thank you for adding this. To prevent any potential confusion for users, it would be beneficial to explicitly state that the Docker image is unofficial and hosted on a personal registry. The current phrasing is a bit ambiguous and users might assume it's an officially maintained image, which could be problematic for long-term support and reliability.

Suggested change
# A pre-built image example, constructed following build-docker-ant.sh, is available on Alibaba Cloud Container Registry:
# crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt
# An unofficial pre-built image example is available on a personal Alibaba Cloud Container Registry:
# crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt

@Haustle-v
Copy link
Author

#603

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale label Dec 25, 2025
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants