-
Notifications
You must be signed in to change notification settings - Fork 26
[Docker image] provide an example of prebuilt ant-ray Docker image #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* [RuntimeEnv] Support custom podman command * Fix empty env keys Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * fix * fix * Add test for output filter --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: He Su <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a comment to the Ant Ray Docker build script documenting the availability and location of a prebuilt Ant Ray Docker image in Alibaba Cloud Container Registry for users who do not want to build the image locally. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @Haustle-v, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the availability of a pre-built Docker image for AntRay development. This change aims to simplify the development environment setup for users by providing a ready-to-use image, directly addressing a common community request. The image is accessible via the Alibaba Cloud Container Registry. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider clarifying in the comment whether this Alibaba Cloud Container Registry image is official/supported and who maintains it, so users understand its status and longevity.
- Hard-coding a personal ACR namespace in the script comment may become stale or misleading over time; you might generalize the example (e.g., placeholder URI) and point to a canonical location (README or docs) for up-to-date image references instead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider clarifying in the comment whether this Alibaba Cloud Container Registry image is official/supported and who maintains it, so users understand its status and longevity.
- Hard-coding a personal ACR namespace in the script comment may become stale or misleading over time; you might generalize the example (e.g., placeholder URI) and point to a canonical location (README or docs) for up-to-date image references instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comment to build-docker-ant.sh pointing to a pre-built Docker image for AntRay, which is a helpful addition for developers. My feedback focuses on improving the clarity of this comment. I've suggested making it explicit that the image is unofficial and hosted on a personal registry to manage user expectations about its official support and long-term stability.
| # A pre-built image example, constructed following build-docker-ant.sh, is available on Alibaba Cloud Container Registry: | ||
| # crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this. To prevent any potential confusion for users, it would be beneficial to explicitly state that the Docker image is unofficial and hosted on a personal registry. The current phrasing is a bit ambiguous and users might assume it's an officially maintained image, which could be problematic for long-term support and reliability.
| # A pre-built image example, constructed following build-docker-ant.sh, is available on Alibaba Cloud Container Registry: | |
| # crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt | |
| # An unofficial pre-built image example is available on a personal Alibaba Cloud Container Registry: | |
| # crpi-3wcszgxf0r7f5bmh.cn-hangzhou.personal.cr.aliyuncs.com/ant-ray/prebuilt |
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
|
This pull request has been automatically closed because there has been no more activity in the 14 days Please feel free to reopen or open a new pull request if you'd still like this to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for your contribution! |
Why are these changes needed?
The community has asked whether AntRay provides a prebuilt Docker image. Currently, there is no official prebuilt image published. This PR addresses the request by providing a ready-to-use docker image for AntRay development, following the
build-docker-ant.sh, and is available from the Alibaba Docker Registry.Related issue number
#603
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.Summary by Sourcery
Documentation: