Skip to content

Conversation

@harryge00
Copy link
Collaborator

Description

Briefly describe what this PR accomplishes and why it's needed.

  1. Always uninstall ray before installing ray, because users' containers may have installed ray, which will be conflicted with hosts' ant-ray

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a change to always uninstall existing ray, ant-ray, and ant-ray-nightly packages before installing a new version. This is achieved by adding an uninstall_ray function and calling it before install_ray_package. The change is sound and helps prevent conflicts with pre-existing installations in user containers. My main feedback is to add error handling to the new uninstall_ray function to ensure that the script fails fast if the uninstallation process encounters an error, preventing potential issues with the subsequent installation.

Copy link
Collaborator

@ffbin ffbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ffbin ffbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale label Jan 20, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants