Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactored batch size logic in pipeline_wan_fun_inpaint_audio.py to handle list-type prompt_embeds gracefully by using len() when appropriate. Class diagram for updated batch size logic in encode_prompt and callclassDiagram
class pipeline_wan_fun_inpaint_audio {
encode_prompt(prompt, prompt_embeds)
__call__(prompt, prompt_embeds)
}
pipeline_wan_fun_inpaint_audio : encode_prompt()
pipeline_wan_fun_inpaint_audio : __call__()
pipeline_wan_fun_inpaint_audio : batch_size
class encode_prompt {
+prompt
+prompt_embeds
+batch_size
}
class __call__ {
+prompt
+prompt_embeds
+batch_size
}
pipeline_wan_fun_inpaint_audio --> encode_prompt
pipeline_wan_fun_inpaint_audio --> __call__
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @xm101, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求解决了 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| batch_size = len(prompt) | ||
| else: | ||
| batch_size = prompt_embeds.shape[0] | ||
| batch_size = len(prompt_embeds) if isinstance(prompt_embeds, list) else prompt_embeds.shape[0] |
There was a problem hiding this comment.
这个获取 batch_size 的逻辑在 __call__ 方法的第 558 行存在重复。为了提高代码的可维护性并避免未来可能出现的不一致，建议将此逻辑提取到一个共享的辅助函数中。虽然这超出了当前修复的范围，但值得在未来的重构中考虑。
| batch_size = len(prompt) | ||
| else: | ||
| batch_size = prompt_embeds.shape[0] | ||
| batch_size = len(prompt_embeds) if isinstance(prompt_embeds, list) else prompt_embeds.shape[0] |
There was a problem hiding this comment.
这个获取 batch_size 的逻辑在 encode_prompt 方法的第 281 行存在重复。为了提高代码的可维护性并避免未来可能出现的不一致，建议将此逻辑提取到一个共享的辅助函数中。虽然这超出了当前修复的范围，但值得在未来的重构中考虑。
1 participant
类型问题
Summary by Sourcery
Fix batch size calculation to support list-type prompt embeddings in pipeline_wan_fun_inpaint_audio.
Bug Fixes: