Fix TaskManager frozen container validation in stress tests#1
Closed
anthony-murphy-agent wants to merge 1 commit intofeat/stress-test-state-trackerfrom
Closed
Fix TaskManager frozen container validation in stress tests#1anthony-murphy-agent wants to merge 1 commit intofeat/stress-test-state-trackerfrom
anthony-murphy-agent wants to merge 1 commit intofeat/stress-test-state-trackerfrom
Conversation
…kip list Frozen containers don't process quorum events (e.g., removeMember), so DDSs like TaskManager whose in-memory state depends on quorum membership will inevitably diverge from a live client. TaskManager's applyStashedOp is also intentionally a no-op, meaning the frozen container isn't expected to reproduce the live client's task queue state. Changes: - Add optional `skipChannelTypes` parameter to `validateConsistencyOfAllDDS` - Define `quorumDependentDdsTypes` set containing the TaskManager type - Pass this set when validating frozen containers in the removeClient reducer - Remove 7 seeds from skip list that now pass (Directory: 1, 14, 45, 155, 184; COC: 54; TaskManager: 137) - Reclassify seed 63 from Directory to COC category - Keep seed 46 (genuine TaskManager live-client consistency bug) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: anthony-murphy <anthony.murphy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeClientreducer. Frozen containers don't process quorum events (removeMember), so TaskManager'staskQueues(which depend on quorum membership) will inevitably diverge.skipChannelTypesparameter tovalidateConsistencyOfAllDDSto support this.Test plan
🤖 Generated with Claude Code