Fix COC consistency: scrub stale jobTracking entries on connect#2
Closed
anthony-murphy-agent wants to merge 1 commit intofix/taskmanager-validationfrom
Closed
Fix COC consistency: scrub stale jobTracking entries on connect#2anthony-murphy-agent wants to merge 1 commit intofix/taskmanager-validationfrom
anthony-murphy-agent wants to merge 1 commit intofix/taskmanager-validationfrom
Conversation
When a new client loads from snapshot + saved ops, it processes historical acquire ops that add items to jobTracking. However, it never receives the removeMember quorum events for clients that left before it joined. This causes items to be permanently stuck in jobTracking on the new client, while long-lived clients correctly returned those items to the queue via their removeMember handlers — producing data divergence between live clients. Fix: override onConnect() in ConsensusOrderedCollection to scrub jobTracking entries for clients no longer in the quorum. This runs after all saved ops are processed and the quorum is current, ensuring stale entries are cleaned up. Also add ConsensusOrderedCollection to the quorumDependentDdsTypes set in the stress test harness, since frozen containers (which never connect) can't perform this scrub. Seeds fixed: 37, 60 (data count divergence) Seeds remaining: 56, 63, 180 (queue ordering divergence — the scrub adds items back at the end of the queue, whereas the original removeMember event happened at a different point during op processing, producing different item ordering) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: anthony-murphy <anthony.murphy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jobTracking) but never receives theremoveMemberquorum events for clients that left before it joined. Items get permanently stuck injobTracking, diverging from long-lived clients that correctly returned those items to the queue.scrubJobTrackingByQuorum()inonConnect()to clean up stale entries after all saved ops are processed and the quorum is current.quorumDependentDdsTypesfor frozen container validation (frozen containers never connect, so the scrub can't run).Test plan
🤖 Generated with Claude Code