Skip to content

Add Header option to SObjectDescribeFull to allow for If-Modified-Since #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahickey-sfdc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Header option to SObjectDescribeFull to allow for If-Modified-Since #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20168cc
Add Header option to SObjectDescribeFull to allow for If-Modified-Sin…
ahickey-sfdc Jun 15, 2022
50910a5
I've added this change to handle the response returned when If-Modifi…
ahickey-sfdc Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/NetCoreForce.Client/ForceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,14 +597,15 @@ public async Task<SObjectBasicInfo> GetObjectBasicInfo(string objectTypeName)
/// <para>Use the SObject Describe resource to retrieve all the metadata for an object, including information about each field, URLs, and child relationships.</para>
/// </summary>
/// <param name="objectTypeName">SObject name, e.g. Account</param>
/// <param name="customHeaders">Example If-Modified-Since: Wed, 3 Jul 2013 19:43:31 GMT</param>
/// <returns>Returns SObjectMetadataAll with full object meta including field metadata</returns>
public async Task<SObjectDescribeFull> GetObjectDescribe(string objectTypeName)
public async Task<SObjectDescribeFull> GetObjectDescribe(string objectTypeName, Dictionary<string, string> customHeaders = null)
{
var uri = UriFormatter.SObjectDescribe(InstanceUrl, ApiVersion, objectTypeName);

JsonClient client = new JsonClient(AccessToken, _httpClient);

return await client.HttpGetAsync<SObjectDescribeFull>(uri);
return await client.HttpGetAsync<SObjectDescribeFull>(uri, customHeaders);
}

/// <summary>
Expand Down
9 changes: 9 additions & 0 deletions src/NetCoreForce.Client/JsonClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,15 @@ private async Task<T> GetResponse<T>(HttpRequestMessage request, Dictionary<stri
return JsonConvert.DeserializeObject<T>(string.Empty);
}

// returned when header If-Modified-Since used and the object requested wasn't modified since provided date
if (responseMessage.StatusCode == HttpStatusCode.NotModified)
{
if (customHeaders != null && customHeaders.ContainsKey("If-Modified-Since"))
{
return JsonConvert.DeserializeObject<T>(string.Empty);
}
}

//sucessful response, skip deserialization of response content
if (responseMessage.IsSuccessStatusCode && !deserializeResponse)
{
Expand Down