Skip to content

refactor: process all streaming events for forward compatibility #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
+14 −28
Open

refactor: process all streaming events for forward compatibility #993

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
109b771
fix(client): close streams without requiring full consumption
stainless-app[bot] Oct 29, 2025
568417a
fix(streaming-performance) - Optimize streaming event processing and …
Jul 5, 2025
8a0a8ae
test: update tests to reflect response.close() cleanup
fede-kamel Oct 28, 2025
cbc3e13
refactor: process all streaming events for forward compatibility
fede-kamel Oct 28, 2025
d93e2b8
Merge main branch and resolve conflicts in _streaming.py
Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 14 additions & 28 deletions src/anthropic/_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,6 @@ def __stream__(self) -> Iterator[_T]:
if sse.event == "completion":
yield process_data(data=sse.json(), cast_to=cast_to, response=response)

if (
sse.event == "message_start"
or sse.event == "message_delta"
or sse.event == "message_stop"
or sse.event == "content_block_start"
or sse.event == "content_block_delta"
or sse.event == "content_block_stop"
):
data = sse.json()
if is_dict(data) and "type" not in data:
data["type"] = sse.event

yield process_data(data=data, cast_to=cast_to, response=response)

if sse.event == "ping":
continue

Expand All @@ -113,6 +99,13 @@ def __stream__(self) -> Iterator[_T]:
response=self.response,
)

# Process any other event for forward compatibility
data = sse.json()
if is_dict(data) and "type" not in data:
data["type"] = sse.event

yield process_data(data=data, cast_to=cast_to, response=response)

# As we might not fully consume the response stream, we need to close it explicitly
response.close()

Expand Down Expand Up @@ -198,20 +191,6 @@ async def __stream__(self) -> AsyncIterator[_T]:
if sse.event == "completion":
yield process_data(data=sse.json(), cast_to=cast_to, response=response)

if (
sse.event == "message_start"
or sse.event == "message_delta"
or sse.event == "message_stop"
or sse.event == "content_block_start"
or sse.event == "content_block_delta"
or sse.event == "content_block_stop"
):
data = sse.json()
if is_dict(data) and "type" not in data:
data["type"] = sse.event

yield process_data(data=data, cast_to=cast_to, response=response)

if sse.event == "ping":
continue

Expand All @@ -230,6 +209,13 @@ async def __stream__(self) -> AsyncIterator[_T]:
response=self.response,
)

# Process any other event for forward compatibility
data = sse.json()
if is_dict(data) and "type" not in data:
data["type"] = sse.event

yield process_data(data=data, cast_to=cast_to, response=response)

# As we might not fully consume the response stream, we need to close it explicitly
await response.aclose()

Expand Down