fix: add leading space to generated field doc comments#5
Merged
iainmcgin merged 2 commits intoanthropics:mainfrom Mar 24, 2026
Merged
fix: add leading space to generated field doc comments#5iainmcgin merged 2 commits intoanthropics:mainfrom
iainmcgin merged 2 commits intoanthropics:mainfrom
Conversation
prettyplease renders `#[doc = "Field ..."]` as `///Field ...` without a space after the slashes. Adding a leading space to the format string produces the standard `/// Field ...` rustdoc style. Fixes anthropics#4 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
|
It looks like the generated code needs regenerated to pass the check that it's in sync; |
6 tasks
iainmcgin
approved these changes
Mar 24, 2026
Collaborator
iainmcgin
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format!()strings that produce#[doc = ...]attributes in the codegen, so prettyplease renders them as/// Field ...instead of///Field ...message.rs(line 1057) andview.rs(lines 312, 322)Fixes #4
Test plan
.protowith message fields now renders/// Field N: ...with a spacecargo test)🤖 Generated with Claude Code