feat: refactor system_prompt to support preset and append options #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicksontsai
previously approved these changes
Sep 26, 2025
| options = ClaudeCodeOptions( | ||
| system_prompt={"preset": "claude_code", "append": "Be concise."}, | ||
| ) | ||
| assert options.system_prompt == { |
Collaborator
There was a problem hiding this comment.
What is this test actually testing?
Collaborator
Author
There was a problem hiding this comment.
Same as what test_claude_code_options_with_system_prompt was testing before, I think? Not a whole lot 😅
Collaborator
There was a problem hiding this comment.
It would be nice to clean this up, but feel free to merge
ashwin-ant
dismissed
dicksontsai’s stale review
The base branch was changed.
Replace separate system_prompt and append_system_prompt fields with a single
system_prompt field that accepts:
- string: custom system prompt
- {"preset": "claude_code"}: use default Claude Code prompt
- {"preset": "claude_code", "append": "..."}: default prompt with additions
- None/undefined: vanilla Claude with no system prompt
This matches the TypeScript SDK API design and provides more flexible
system prompt configuration.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Update SystemPromptPreset to include required type: "preset" field alongside preset: "claude_code", matching the TypeScript SDK structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ashwin-ant
force-pushed
the
ashwin/systemprompt
branch
from
cf1edb4 to
d9dbf2c
Compare
dicksontsai
approved these changes
Sep 26, 2025
| options = ClaudeCodeOptions( | ||
| system_prompt={"preset": "claude_code", "append": "Be concise."}, | ||
| ) | ||
| assert options.system_prompt == { |
Collaborator
There was a problem hiding this comment.
It would be nice to clean this up, but feel free to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace separate system_prompt and append_system_prompt fields with a single system_prompt field that accepts:
This matches the TypeScript SDK API design and provides more flexible system prompt configuration.
🤖 Generated with Claude Code