fix: add support for thinking content blocks #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ltawfik I fixed types as well, and merged latest main branch. Can you review? thanks. |
Contributor
|
@dicksontsai @shunfu is there a reason why this pr can't be merged? |
Collaborator
|
No specific reason, I can fix it up and merge it |
Contributor
|
thank you! |
shunfu
approved these changes
Aug 6, 2025
rushilpatel0
pushed a commit
to codegen-sh/claude-code-sdk-python
that referenced
this pull request
Aug 17, 2025
## Summary
Fixes an issue where `thinking` content blocks in Claude Code responses
were not being parsed, resulting in empty `AssistantMessage` content
arrays.
## Changes
- Added `ThinkingBlock` dataclass to handle thinking content with
`thinking` and `signature` fields
- Updated client parsing logic in `_internal/client.py` to recognize and
create `ThinkingBlock` instances
- Added comprehensive test coverage for thinking block functionality
## Before
```python
# Claude Code response with thinking block resulted in:
AssistantMessage(content=[]) # Empty content!
```
## After
```python
# Now correctly parses to:
AssistantMessage(content=[
ThinkingBlock(thinking="...", signature="...")
])
```
Fixes anthropics#27
---------
Co-authored-by: Dickson Tsai <dickson@anthropic.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
dicksontsai
pushed a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
thinkingcontent blocks in Claude Code responses were not being parsed, resulting in emptyAssistantMessagecontent arrays.Changes
ThinkingBlockdataclass to handle thinking content withthinkingandsignaturefields_internal/client.pyto recognize and createThinkingBlockinstancesBefore
After
Fixes #27