Skip to content

fix: Handle ProcessTransport race condition in control request handlers #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elad12390 wants to merge 1 commit into from
Closed

fix: Handle ProcessTransport race condition in control request handlers #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/claude_agent_sdk/_internal/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,13 @@ async def _handle_control_request(self, request: SDKControlRequest) -> None:
"response": response_data,
},
}
await self.transport.write(json.dumps(success_response) + "\n")
try:
await self.transport.write(json.dumps(success_response) + "\n")
except Exception as write_err:
# Transport not ready (likely during cleanup) - log but don't fail
logger.debug(
f"Could not write control response (transport not ready): {write_err}"
)

except Exception as e:
# Send error response
Expand All @@ -312,7 +318,13 @@ async def _handle_control_request(self, request: SDKControlRequest) -> None:
"error": str(e),
},
}
await self.transport.write(json.dumps(error_response) + "\n")
try:
await self.transport.write(json.dumps(error_response) + "\n")
except Exception as write_err:
# Transport not ready (likely during cleanup) - log but don't fail
logger.debug(
f"Could not write error response (transport not ready): {write_err}"
)

async def _send_control_request(self, request: dict[str, Any]) -> dict[str, Any]:
"""Send control request to CLI and wait for response."""
Expand Down