Skip to content

fix: remove emojis from build_wheel.py for Windows compatibility #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashwin-ant merged 1 commit into from
Nov 19, 2025
Merged

fix: remove emojis from build_wheel.py for Windows compatibility #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions scripts/build_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
def run_command(cmd: list[str], description: str) -> None:
"""Run a command and handle errors."""
print(f"\n{'=' * 60}")
print(f"📦 {description}")
print(f"{description}")
print(f"{'=' * 60}")
print(f"$ {' '.join(cmd)}")
print()
Expand All @@ -49,7 +49,7 @@ def run_command(cmd: list[str], description: str) -> None:
)
print(result.stdout)
except subprocess.CalledProcessError as e:
print(f"❌ Error: {description} failed", file=sys.stderr)
print(f"Error: {description} failed", file=sys.stderr)
print(e.stdout, file=sys.stderr)
sys.exit(1)

Expand All @@ -60,7 +60,7 @@ def update_version(version: str) -> None:
update_script = script_dir / "update_version.py"

if not update_script.exists():
print("⚠️ Warning: update_version.py not found, skipping version update")
print("Warning: update_version.py not found, skipping version update")
return

run_command(
Expand Down Expand Up @@ -105,10 +105,10 @@ def clean_dist() -> None:
dist_dir = Path("dist")
if dist_dir.exists():
print(f"\n{'=' * 60}")
print("🧹 Cleaning dist directory")
print("Cleaning dist directory")
print(f"{'=' * 60}")
shutil.rmtree(dist_dir)
print("✓ Cleaned dist/")
print("Cleaned dist/")


def get_platform_tag() -> str:
Expand Down Expand Up @@ -152,7 +152,7 @@ def get_platform_tag() -> str:
def retag_wheel(wheel_path: Path, platform_tag: str) -> Path:
"""Retag a wheel with the correct platform tag using wheel package."""
print(f"\n{'=' * 60}")
print("🏷️ Retagging wheel as platform-specific")
print("Retagging wheel as platform-specific")
print(f"{'=' * 60}")
print(f"Old: {wheel_path.name}")

Expand All @@ -173,7 +173,7 @@ def retag_wheel(wheel_path: Path, platform_tag: str) -> Path:
)

if result.returncode != 0:
print(f"⚠️ Warning: Failed to retag wheel: {result.stderr}")
print(f"Warning: Failed to retag wheel: {result.stderr}")
return wheel_path

# Find the newly tagged wheel
Expand All @@ -184,15 +184,15 @@ def retag_wheel(wheel_path: Path, platform_tag: str) -> Path:
if new_wheels:
new_path = new_wheels[0]
print(f"New: {new_path.name}")
print("✓ Wheel retagged successfully")
print("Wheel retagged successfully")

# Remove the old wheel
if wheel_path.exists() and wheel_path != new_path:
wheel_path.unlink()

return new_path
else:
print("⚠️ Warning: Could not find retagged wheel")
print("Warning: Could not find retagged wheel")
return wheel_path


Expand Down Expand Up @@ -221,9 +221,9 @@ def build_wheel() -> None:
if "-any.whl" in wheel.name:
retag_wheel(wheel, platform_tag)
else:
print("⚠️ Warning: No wheel found to retag")
print("Warning: No wheel found to retag")
else:
print("\nℹ️ No bundled CLI found - wheel will be platform-independent")
print("\nNo bundled CLI found - wheel will be platform-independent")


def build_sdist() -> None:
Expand All @@ -237,12 +237,12 @@ def build_sdist() -> None:
def check_package() -> None:
"""Check package with twine."""
if not HAS_TWINE:
print("\n⚠️ Warning: twine not installed, skipping package check")
print("\nWarning: twine not installed, skipping package check")
print("Install with: pip install twine")
return

print(f"\n{'=' * 60}")
print("📦 Checking package with twine")
print("Checking package with twine")
print(f"{'=' * 60}")
print(f"$ {sys.executable} -m twine check dist/*")
print()
Expand All @@ -258,13 +258,13 @@ def check_package() -> None:
print(result.stdout)

if result.returncode != 0:
print("\n⚠️ Warning: twine check reported issues")
print("\nWarning: twine check reported issues")
print("Note: 'License-File' warnings are false positives from twine 6.x")
print("PyPI will accept these packages without issues")
else:
print("✓ Package check passed")
print("Package check passed")
except Exception as e:
print(f"⚠️ Warning: Failed to run twine check: {e}")
print(f"Warning: Failed to run twine check: {e}")


def clean_bundled_cli() -> None:
Expand All @@ -274,14 +274,14 @@ def clean_bundled_cli() -> None:

if cli_files:
print(f"\n{'=' * 60}")
print("🧹 Cleaning bundled CLI")
print("Cleaning bundled CLI")
print(f"{'=' * 60}")
for cli_file in cli_files:
if cli_file.name != ".gitignore":
cli_file.unlink()
print(f"✓ Removed {cli_file}")
print(f"Removed {cli_file}")
else:
print("\nℹ️ No bundled CLI to clean")
print("\nNo bundled CLI to clean")


def list_artifacts() -> None:
Expand All @@ -291,7 +291,7 @@ def list_artifacts() -> None:
return

print(f"\n{'=' * 60}")
print("📦 Built Artifacts")
print("Built Artifacts")
print(f"{'=' * 60}")

artifacts = sorted(dist_dir.iterdir())
Expand Down Expand Up @@ -345,7 +345,7 @@ def main() -> None:
args = parser.parse_args()

print("\n" + "=" * 60)
print("🚀 Claude Agent SDK - Wheel Builder")
print("Claude Agent SDK - Wheel Builder")
print("=" * 60)

# Clean dist if requested
Expand All @@ -360,7 +360,7 @@ def main() -> None:
if not args.skip_download:
download_cli(args.cli_version)
else:
print("\nℹ️ Skipping CLI download (using existing)")
print("\nSkipping CLI download (using existing)")

# Build wheel
build_wheel()
Expand All @@ -380,7 +380,7 @@ def main() -> None:
list_artifacts()

print(f"\n{'=' * 60}")
print("✅ Build complete!")
print("Build complete!")
print(f"{'=' * 60}")
print("\nNext steps:")
print(" 1. Test the wheel: pip install dist/*.whl")
Expand Down
Loading