Skip to content

Conversation

@dicksontsai
Copy link
Collaborator

@dicksontsai dicksontsai commented Nov 19, 2025

Summary

  • Adds optional timeout field to HookMatcher dataclass in types.py that allows users to specify a custom timeout (in seconds) for hooks
  • Propagates the timeout value through:
    • client.py and _internal/client.py: _convert_hooks_to_internal() method
    • _internal/query.py: hook config sent to CLI

Test plan

  • Verify hooks work without timeout specified (default behavior)
  • Verify custom timeout is passed to CLI when specified in HookMatcher

🤖 Generated with Claude Code

Add optional timeout field to HookMatcher type that allows users to
specify a custom timeout (in seconds) for hooks in a matcher. The
timeout is propagated through the internal client and query layer
to be passed to the CLI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@dicksontsai dicksontsai marked this pull request as ready for review November 19, 2025 20:45
@dicksontsai dicksontsai requested a review from a team November 19, 2025 20:45
@dicksontsai dicksontsai merged commit 84edd73 into main Nov 19, 2025
98 of 102 checks passed
@dicksontsai dicksontsai deleted the dickson/hook-timeout branch November 19, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants