fix: handle JSON messages split across multiple stream reads #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds buffering to accumulate incomplete JSON messages that are split across multiple stream reads due to asyncio's 64KB default buffer limit. - Implement 1MB buffer to accumulate partial JSON - Clear buffer on successful parse or size limit exceeded - Add comprehensive tests for split JSON scenarios Fixes CLIJSONDecodeError when reading large minified JSON files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The CLIJSONDecodeError constructor expects an Exception as the second argument, not None. Changed to pass a ValueError with details about the buffer size limit being exceeded. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This was referenced Jul 1, 2025
Removed redundant comments that simply restate what the code is doing. Kept only comments that provide valuable context or explain complex behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
igorkofman
approved these changes
Jul 1, 2025
igorkofman
previously approved these changes
Jul 1, 2025
kushal-thakkar
previously approved these changes
Jul 1, 2025
igorkofman
approved these changes
Jul 1, 2025
kushal-thakkar
approved these changes
Jul 1, 2025
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLIJSONDecodeError when Claude Code CLI returns large JSON messages that exceed asyncio's default 64KB stream buffer limit.
Problem
When JSON messages are larger than the stream buffer, they arrive split across multiple reads. The previous implementation attempted to parse each fragment immediately, resulting in JSONDecodeError.
Solution
Testing
Added comprehensive test coverage:
🤖 Generated with Claude Code